Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dnsmasq is restarted during upgrades #10112

Merged

Conversation

michaelgugino
Copy link
Contributor

Currently, upgrades are failing because sdn pod
does not notify dnsmasq to update dns server list.

This commit ensures dnsmasq is restarted before docker
is restarted so static pods get valid networking.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629700

Currently, upgrades are failing because sdn pod
does not notify dnsmasq to update dns server list.

This commit ensures dnsmasq is restarted before docker
is restarted so static pods get valid networking.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629700
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2018
@sdodson
Copy link
Member

sdodson commented Sep 17, 2018

/lgtm
/cherrypick release-3.11
/priority p0
This shouldn't be necessary but no harm should come of it since if the SDN pod is working properly it will repopulate dnsmasq config after 30 seconds.

@openshift-cherrypick-robot

@sdodson: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/lgtm
/cherrypick release-3.11
/priority p0
This shouldn't be necessary but no harm should come of it since if the SDN pod is working properly it will repopulate dnsmasq config after 30 seconds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added priority/P0 lgtm Indicates that a PR is ready to be merged. labels Sep 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelgugino
Copy link
Contributor Author

/cherrypick release-3.10

@openshift-cherrypick-robot

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Sep 17, 2018

/retest

@openshift-ci-robot
Copy link

@michaelgugino: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp-crio 305ab18 link /test gcp-crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@sdodson: new pull request created: #10115

In response to this:

/lgtm
/cherrypick release-3.11
/priority p0
This shouldn't be necessary but no harm should come of it since if the SDN pod is working properly it will repopulate dnsmasq config after 30 seconds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@michaelgugino: new pull request created: #10116

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/P0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants