Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.11] Ensure dnsmasq is restarted during upgrades #10115

Merged
merged 1 commit into from Sep 17, 2018
Merged

[release-3.11] Ensure dnsmasq is restarted during upgrades #10115

merged 1 commit into from Sep 17, 2018

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #10112

/assign sdodson

@michaelgugino
Ensure dnsmasq is restarted during upgrades
367b029 
Currently, upgrades are failing because sdn pod
does not notify dnsmasq to update dns server list.

This commit ensures dnsmasq is restarted before docker
is restarted so static pods get valid networking.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629700
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 17, 2018
Merged
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mtnbikenc

If they are not already assigned, you can assign the PR to them by writing /assign @mtnbikenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson merged commit 2c192b7 into openshift:release-3.11 Sep 17, 2018
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 367b029 link /test gcp
ci/prow/gcp-crio 367b029 link /test gcp-crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson Awaiting requested review from sdodson

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@sdodson sdodson

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @sdodson @michaelgugino