Ensure atomic hosts prepull node image during pre-upgrade

[michaelgugino]

Currently, atomic hosts do not prepull the node image
during pre-upgrade step. This commit refactors image
prepulling to ensure it happens at the approriate times
for both install and upgrades and properly accounts for
atomic host.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629558

[vrutkovs]

/test gcp-major-upgrade

[sdodson]

handler name should be reload systemd units

[michaelgugino]

/test gcp-major-upgrade

[michaelgugino]

/test gcp

[sdodson]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [michaelgugino,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michaelgugino]

/cherrypick release-3.11

[openshift-cherrypick-robot]

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

/cherrypick release-3.10

[openshift-cherrypick-robot]

@michaelgugino: once the present PR merges, I will cherry-pick it on top of release-3.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michaelgugino]

Looks like flake.

/test gcp-major-upgrade

[openshift-cherrypick-robot]

@michaelgugino: new pull request created: #10135

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@michaelgugino: #10125 failed to apply on top of branch "release-3.10":

Using index info to reconstruct a base tree...
M	roles/openshift_node/tasks/config.yml
M	roles/openshift_node/tasks/main.yml
M	roles/openshift_node/tasks/node_system_container.yml
A	roles/openshift_node/tasks/prepull.yml
M	roles/openshift_node/tasks/upgrade.yml
M	roles/openshift_node/tasks/upgrade/config_changes.yml
M	roles/openshift_node/tasks/upgrade_pre.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_node/tasks/upgrade_pre.yml
CONFLICT (content): Merge conflict in roles/openshift_node/tasks/upgrade_pre.yml
Auto-merging roles/openshift_node/tasks/upgrade/config_changes.yml
Auto-merging roles/openshift_node/tasks/upgrade.yml
CONFLICT (modify/delete): roles/openshift_node/tasks/prepull.yml deleted in HEAD and modified in Ensure atomic hosts prepull node image during pre-upgrade. Version Ensure atomic hosts prepull node image during pre-upgrade of roles/openshift_node/tasks/prepull.yml left in tree.
Auto-merging roles/openshift_node/tasks/node_system_container.yml
CONFLICT (content): Merge conflict in roles/openshift_node/tasks/node_system_container.yml
Auto-merging roles/openshift_node/tasks/main.yml
Auto-merging roles/openshift_node/tasks/config.yml
error: Failed to merge in the changes.
Patch failed at 0001 Ensure atomic hosts prepull node image during pre-upgrade

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@michaelgugino: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/gcp	783085a	link	/test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.