[3.10] Ensure atomic hosts prepull node image during pre-upgrade #10136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
michaelgugino
force-pushed
the
fix-atomic-upgrade-prepull-bp-3.10
branch
from
913c3d8
to
0fab872
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
michaelgugino
commented
Sep 18, 2018
| @@ -6,6 +6,9 @@ | |||
| - openshift_deployment_type == 'openshift-enterprise' | |||
| - not openshift_use_crio | bool | |||
|
|
|||
| - name: Start node image prepull | |||
There was a problem hiding this comment.
Had to add this, 3.11 and master have prepull, 3.10 doesn't.
|
Needs: #10138 |
michaelgugino
force-pushed
the
fix-atomic-upgrade-prepull-bp-3.10
branch
2 times, most recently
from
ecf802b
to
f71bae9
Compare
|
/retest |
Currently, atomic hosts do not prepull the node image during pre-upgrade step. This commit refactors image prepulling to ensure it happens at the approriate times for both install and upgrades and properly accounts for atomic host. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629558 (cherry picked from commit 783085a)
michaelgugino
force-pushed
the
fix-atomic-upgrade-prepull-bp-3.10
branch
from
f71bae9
to
7c714fd
Compare
|
/test gcp |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, atomic hosts do not prepull the node image
during pre-upgrade step. This commit refactors image
prepulling to ensure it happens at the approriate times
for both install and upgrades and properly accounts for
atomic host.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1629558
(cherry picked from commit 783085a)
Backports: #10125
Backport Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1631021