New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding container.yaml #10168

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
6 participants
@adammhaile
Contributor

adammhaile commented Sep 20, 2018

@sdodson This is for testing the new ODCS requirements as we discussed.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Sep 20, 2018

Member

This file should probably be exempt from yaml linting, but the fix looks straight forward enough, can we update it to remove the whitespace?

images/installer/container.yaml:
14:1 error too many blank lines (1 > 0) (empty-lines)

Member

sdodson commented Sep 20, 2018

This file should probably be exempt from yaml linting, but the fix looks straight forward enough, can we update it to remove the whitespace?

images/installer/container.yaml:
14:1 error too many blank lines (1 > 0) (empty-lines)

@adammhaile

This comment has been minimized.

Show comment
Hide comment
@adammhaile

adammhaile Sep 20, 2018

Contributor

@sdodson how dare the yaml rules be different from python.
Fixed now.

Contributor

adammhaile commented Sep 20, 2018

@sdodson how dare the yaml rules be different from python.
Fixed now.

@adammhaile

This comment has been minimized.

Show comment
Hide comment
@adammhaile

adammhaile Sep 20, 2018

Contributor

@sdodson that file should lint fine now

Contributor

adammhaile commented Sep 20, 2018

@sdodson that file should lint fine now

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Sep 20, 2018

Member

/lgtm
/cherrypick master

Member

sdodson commented Sep 20, 2018

/lgtm
/cherrypick master

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Sep 20, 2018

@sdodson: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/lgtm
/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Sep 20, 2018

@sdodson: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/lgtm
/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adammhaile, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot commented Sep 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adammhaile, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Sep 20, 2018

Member

/retest

Please review the full test history for this PR and help us cut down flakes.

Member

openshift-bot commented Sep 20, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3368fb1 into openshift:release-3.11 Sep 20, 2018

9 checks passed

ci/openshift-jenkins/gcp Skipped
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/logging Skipped
ci/openshift-jenkins/tox Skipped
ci/prow/gcp Job succeeded.
Details
ci/prow/gcp-crio Skipped
ci/prow/unit Job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Sep 20, 2018

@sdodson: new pull request created: #10175

In response to this:

/lgtm
/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Sep 20, 2018

@sdodson: new pull request created: #10175

In response to this:

/lgtm
/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment