Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles/openshift-prometheus: fix failing prometheus service discovery … #10428

Merged
merged 1 commit into from Oct 25, 2018
Merged

roles/openshift-prometheus: fix failing prometheus service discovery … #10428

merged 1 commit into from Oct 25, 2018

Conversation

pgier
Copy link
Contributor

@pgier pgier commented Oct 17, 2018 •
edited by vrutkovs

…scrapes

  • remove containerPort config from alertmanager and alertbuffer so that the prometheus
    kube discovery doesn't try to scrape them
  • allow unauthenticated access to /metrics path so alert buffer can be scraped

Cherrypick of #10424 on release-3.7

@pgier
roles/openshift-prometheus: fix failing prometheus service discovery …
c8a19d6 
…scrapes

- remove containerPort config from alertmanager and alertbuffer so that the prometheus
  kube discovery doesn't try to scrape them
- allow unauthenticated access to /metrics path so alert buffer can be scraped
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018
@pgier
Copy link
Contributor Author

pgier commented Oct 17, 2018

backporting fix for bz1639097

@pgier
Copy link
Contributor Author

pgier commented Oct 17, 2018

/test gcp
/test install

@pgier
Copy link
Contributor Author

pgier commented Oct 17, 2018

/assign vrutkovs

@pgier
Copy link
Contributor Author

pgier commented Oct 17, 2018

bot, retest this please

@vrutkovs
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pgier, vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs requested a review from sdodson October 17, 2018 16:41
@pgier
Copy link
Contributor Author

pgier commented Oct 17, 2018

/test gcp
/test install

@pgier
Copy link
Contributor Author

pgier commented Oct 18, 2018

/test gcp install

2 similar comments
@pgier
Copy link
Contributor Author

pgier commented Oct 19, 2018

/test gcp install

@pgier
Copy link
Contributor Author

pgier commented Oct 24, 2018

/test gcp install

@openshift-ci-robot
Copy link

@pgier: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/install c8a19d6 link /test install
ci/openshift-jenkins/gcp c8a19d6 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson merged commit addf380 into openshift:release-3.7 Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@vrutkovs vrutkovs

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pgier @vrutkovs @openshift-ci-robot @sdodson