Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first_master_client_binary from hostvars[groups.oo_first_master.0] #10429

Conversation

michaelgugino
Copy link
Contributor

@michaelgugino michaelgugino commented Oct 17, 2018

Since first_master_client_binary is initialized in oo_first_master, it
should be collected from oo_first_master.0. This patch changes to use
first_master_client_binary from hostvars[groups.oo_first_master.0] on
GlusterFS cluster health task.

(cherry picked from commit b726dda)

Backports: #9924
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1636018

Since first_master_client_binary is initialized in oo_first_master, it
should be collected from oo_first_master.0. This patch changes to use
first_master_client_binary from hostvars[groups.oo_first_master.0] on
GlusterFS cluster health task.

(cherry picked from commit b726dda)
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@michaelgugino michaelgugino added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: michaelgugino, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelgugino
Copy link
Contributor Author

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit 180d8b2 into openshift:release-3.9 Oct 17, 2018
@openshift-ci-robot
Copy link

@michaelgugino: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 077c801 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants