Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.10] Update router service when its annotation changes #11122

Merged
merged 1 commit into from Feb 5, 2019
Merged

[release-3.10] Update router service when its annotation changes #11122

merged 1 commit into from Feb 5, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #11100

/assign Miciah

@Miciah
Update router service when its annotation changes
6b5a4c4 
This commit fixes bug 1635613.

https://bugzilla.redhat.com/show_bug.cgi?id=1635613

* roles/lib_openshift/library/oc_adm_router.py (Router.needs_update):
* roles/lib_openshift/src/class/oc_adm_router.py (Router.needs_update):
Check whether the service.alpha.openshift.io/serving-cert-secret-name
annotation on the service differs between the user and result definitions.
* roles/lib_openshift/src/test/unit/test_oc_adm_router.py (RouterTest): Add
tests to verify that oc_adm_router replaces an existing deployment or
service if an old, outdated one exists.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2019
@Miciah
Copy link
Contributor

Miciah commented Feb 5, 2019 

ClientError: An error occurred (InvalidPermission.Duplicate) when calling the AuthorizeSecurityGroupIngress operation: the specified rule "peer: 0.0.0.0/0, ALL, ALLOW" already exists

/test e2e-atomic

@Miciah
Copy link
Contributor

Miciah commented Feb 5, 2019 

fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["/tmp/openshift_gcp_provision.sh"], "delta": "0:00:58.412217", "end": "2019-02-05 01:30:33.686701", "msg": "non-zero return code", "rc": 1, "start": "2019-02-05 01:29:35.274484", "stderr": "WARNING: mode is deprecated. Please use subnet-mode instead.\nERROR: (gcloud.compute.networks.create) Could not fetch resource:\n - Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally.", "stderr_lines": ["WARNING: mode is deprecated. Please use subnet-mode instead.", "ERROR: (gcloud.compute.networks.create) Could not fetch resource:", " - Quota 'SUBNETWORKS' exceeded.  Limit: 450.0 globally."], "stdout": "", "stdout_lines": []}

/test gcp

@Miciah
Copy link
Contributor

Miciah commented Feb 5, 2019

/retest

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging 6b5a4c4 link /test logging
ci/openshift-jenkins/install 6b5a4c4 link /test install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member

vrutkovs commented Feb 5, 2019

/skip
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4a1bcb8 into openshift:release-3.10 Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@vrutkovs vrutkovs

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @Miciah @openshift-ci-robot @vrutkovs @openshift-merge-robot