Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1689149 - adding secret names to SA for whitelisting #11359

Conversation

ewolinetz
Copy link
Contributor

Addresses issue where secrets are required to be whitelisted for service accounts.
Affects releases:

  • 3.11
  • 3.10
  • 3.9

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1689149

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2019

@ewolinetz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 1f86f2e link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roles/openshift_logging_elasticsearch/tasks/main.yaml:
  70:7      error    wrong indentation: expected 4 but found 6  (indentation)
  79:7      error    wrong indentation: expected 4 but found 6  (indentation)
roles/openshift_logging_mux/tasks/main.yaml:
  59:3      error    wrong indentation: expected 4 but found 2  (indentation)
  106:5     error    wrong indentation: expected 6 but found 4  (indentation)
  127:5     error    wrong indentation: expected 6 but found 4  (indentation)
  148:5     error    wrong indentation: expected 6 but found 4  (indentation)
  152:5     error    wrong indentation: expected 6 but found 4  (indentation)
  166:5     error    wrong indentation: expected 6 but found 4  (indentation)
  203:3     error    wrong indentation: expected 4 but found 2  (indentation)
  212:5     error    wrong indentation: expected 6 but found 4  (indentation)
yamllint issues found

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2019
@ewolinetz
Copy link
Contributor Author

@vrutkovs travis passed

Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7e612af into openshift:release-3.11 Mar 18, 2019
@ewolinetz
Copy link
Contributor Author

/cherrypick release-3.10
/cherrypick release-3.9

@openshift-cherrypick-robot

@ewolinetz: #11359 failed to apply on top of branch "release-3.10":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	roles/openshift_logging_curator/tasks/main.yaml
M	roles/openshift_logging_elasticsearch/tasks/main.yaml
M	roles/openshift_logging_fluentd/tasks/main.yaml
M	roles/openshift_logging_kibana/tasks/main.yaml
M	roles/openshift_logging_mux/tasks/main.yaml
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_logging_mux/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_mux/tasks/main.yaml
Auto-merging roles/openshift_logging_kibana/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_kibana/tasks/main.yaml
Auto-merging roles/openshift_logging_fluentd/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_fluentd/tasks/main.yaml
Auto-merging roles/openshift_logging_elasticsearch/tasks/main.yaml
Auto-merging roles/openshift_logging_curator/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_curator/tasks/main.yaml
Patch failed at 0001 Bug 1689149 - adding secret names to SA for whitelisting

In response to this:

/cherrypick release-3.10
/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

/cherrypick release-3.9

@openshift-cherrypick-robot

@ewolinetz: #11359 failed to apply on top of branch "release-3.9":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	roles/openshift_logging_curator/tasks/main.yaml
M	roles/openshift_logging_elasticsearch/tasks/main.yaml
M	roles/openshift_logging_fluentd/tasks/main.yaml
M	roles/openshift_logging_kibana/tasks/main.yaml
M	roles/openshift_logging_mux/tasks/main.yaml
Falling back to patching base and 3-way merge...
Auto-merging roles/openshift_logging_mux/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_mux/tasks/main.yaml
Auto-merging roles/openshift_logging_kibana/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_kibana/tasks/main.yaml
Auto-merging roles/openshift_logging_fluentd/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_fluentd/tasks/main.yaml
Auto-merging roles/openshift_logging_elasticsearch/tasks/main.yaml
Auto-merging roles/openshift_logging_curator/tasks/main.yaml
CONFLICT (content): Merge conflict in roles/openshift_logging_curator/tasks/main.yaml
Patch failed at 0001 Bug 1689149 - adding secret names to SA for whitelisting

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_3.9 affects_3.10 affects_3.11 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants