New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1689149 - adding secret names to SA for whitelisting #11359
Bug 1689149 - adding secret names to SA for whitelisting #11359
Conversation
@ewolinetz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1f86f2e
to
f4fbde9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roles/openshift_logging_elasticsearch/tasks/main.yaml:
70:7 error wrong indentation: expected 4 but found 6 (indentation)
79:7 error wrong indentation: expected 4 but found 6 (indentation)
roles/openshift_logging_mux/tasks/main.yaml:
59:3 error wrong indentation: expected 4 but found 2 (indentation)
106:5 error wrong indentation: expected 6 but found 4 (indentation)
127:5 error wrong indentation: expected 6 but found 4 (indentation)
148:5 error wrong indentation: expected 6 but found 4 (indentation)
152:5 error wrong indentation: expected 6 but found 4 (indentation)
166:5 error wrong indentation: expected 6 but found 4 (indentation)
203:3 error wrong indentation: expected 4 but found 2 (indentation)
212:5 error wrong indentation: expected 6 but found 4 (indentation)
yamllint issues found
f4fbde9
to
06aaacf
Compare
@vrutkovs travis passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, richm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-3.10 |
@ewolinetz: #11359 failed to apply on top of branch "release-3.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.9 |
@ewolinetz: #11359 failed to apply on top of branch "release-3.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses issue where secrets are required to be whitelisted for service accounts.
Affects releases:
ref: https://bugzilla.redhat.com/show_bug.cgi?id=1689149