New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmpfile.d file clears the cni config on boot #11470
tmpfile.d file clears the cni config on boot #11470
Conversation
cherry-pick e0bd10b PR 11409 from release-3.11 Networking is ready when the /etc/cni/net.d/80-openshift-network.conf exists. When the host is rebooted or power cycled, this file is still on the disk and the cluster immediately starts creating pods. This change deletes the file before the cluster node is started. roles/openshift_node/templates/cleanup-cni.j2 is the tmpfile.d file that does the delete, tasks/systemd_units.yml is the playbook that references it. Add a lifecycle: preStop hook to the delete the files. Also deletes ovs db on boot (contents are invalid after boot) SDN-329 - Create a systemd unit that clears the cni configuration directory on boot https://jira.coreos.com/browse/SDN-329 Part of solution to: Bug 1654044 - OCP 3.11: pods end up in CrashLoopBackOff state after a rolling reboot of the node Signed-off-by: Phil Cameron <pcameron@redhat.com>
|
@runcom I cherry picked RE11409 into 3.10 (the automatic cherrypick had a problem) PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
/lgtm |
|
@pecameron: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pecameron, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
cherry-pick e0bd10b
PR 11409 from release-3.11
Networking is ready when the /etc/cni/net.d/80-openshift-network.conf
exists. When the host is rebooted or power cycled, this file is
still on the disk and the cluster immediately starts creating pods.
This change deletes the file before the cluster node is started.
roles/openshift_node/templates/cleanup-cni.j2 is the tmpfile.d file that does the delete,
tasks/systemd_units.yml is the playbook that references it.
Add a lifecycle: preStop hook to the delete the files.
Also deletes ovs db on boot (contents are invalid after boot)
SDN-329 - Create a systemd unit that clears the cni configuration directory on boot
https://jira.coreos.com/browse/SDN-329
Part of solution to:
Bug 1654044 - OCP 3.11: pods end up in CrashLoopBackOff state after a rolling reboot of the node
Signed-off-by: Phil Cameron pcameron@redhat.com