Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.11] OWNERS File Audit #11486

Merged
merged 1 commit into from Apr 18, 2019

Conversation

@mtnbikenc
Copy link
Member

mtnbikenc commented Apr 11, 2019

  • Core openshift-ansible team members only listed in root OWNERS file
  • Adds roles/openshift_ovirt/OWNERS

Please review the files you are listed in to ensure they are current. If you are the only person listed, please suggest additional alternates. If no change is required, a 馃憤 reaction on the PR description is sufficient. Thanks!

Summary of all approvers/reviewers for mentioning:

grep -r " - " --include "OWNERS" . | awk '{print "@"$(NF)}' | sort | uniq | tr '\n' ' '

@abutcher @alecmerdler @ashcrow @aveshagarwal @bparees @brancz @csrwng @dgoodwin @dymurray @ecordell @elad661 @ewolinetz @fabianvf @frobware @ingvagabund @ironcladlou @jarrpa @jboyd01 @jcantrill @jcpowermac @jeremyeder @jim-minter @jmencak @joelsmith @jpeeler @jsanda @jstuever @jwforres @kwoodson @luis5tb @mrunalp @mtnbikenc @mxinden @njhale @patrickdillon @pweil- @ravisantoshgudimetla @rgolangh @richm @sdodson @shawn-hurley @smarterclayton @sosiouxme @spadgett @sross @tomassedovic @tzumainn @vrutkovs @wozniakjan @zgalor

50 approvers/reviewers

@openshift-ci-robot openshift-ci-robot requested review from abutcher and bparees Apr 11, 2019

@mtnbikenc mtnbikenc requested review from sdodson, patrickdillon, vrutkovs, jstuever and jcpowermac and removed request for abutcher and bparees Apr 11, 2019

@mtnbikenc mtnbikenc self-assigned this Apr 11, 2019

@bparees

This comment has been minimized.

Copy link
Contributor

bparees commented Apr 11, 2019

@mtnbikenc i should not be a reviewer anywhere and @adambkaplan should be an approver+reviewer everywhere i currently am. (you can leave me as an approver everywhere i currently am)

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Apr 11, 2019

I am not listed which is accurate 馃槃

@mtnbikenc

This comment has been minimized.

Copy link
Member Author

mtnbikenc commented Apr 11, 2019

@ashcrow

I am not listed which is accurate

$ grep -r ashcrow --include "OWNERS"
roles/openshift_docker_gc/OWNERS:  - ashcrow
roles/openshift_docker_gc/OWNERS:  - ashcrow
@jcantrill
Copy link
Contributor

jcantrill left a comment

馃憤

@jboyd01

This comment has been minimized.

Copy link
Member

jboyd01 commented Apr 11, 2019

On the service-catalog front:

examples/service-catalog/OWNERS:
- jpeeler
+ shawn-hurley (approver+reviewer)
+ jmrodri (approver+reviewer)

pkg/oc/clusteradd/components/service-catalog/OWNERS:
- jpeeler
+ jboyd01 (approver+reviewer)
+ shawn-hurley (approver+reviewer)
+ jmrodri (approver+reviewer)
@shawn-hurley

This comment has been minimized.

Copy link
Contributor

shawn-hurley commented Apr 11, 2019

馃憤

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Apr 12, 2019

@ashcrow

I am not listed which is accurate

$ grep -r ashcrow --include "OWNERS"
roles/openshift_docker_gc/OWNERS:  - ashcrow
roles/openshift_docker_gc/OWNERS:  - ashcrow

Took me a while but you're right, it's in other branches. There are other folks who are owners for openshift_docker_gc, and I should no longer be an owner. Do I need to do a PR to remove myself from the branches?

@mtnbikenc

This comment has been minimized.

Copy link
Member Author

mtnbikenc commented Apr 12, 2019

Do I need to do a PR to remove myself from the branches?

@ashcrow This is for the 3.11 branch and I'm going to backport all this to previous branches.

@jmencak

This comment has been minimized.

Copy link
Contributor

jmencak commented Apr 13, 2019

馃憤 /cc @jeremyeder, @zvonkok, @sjug

@rgolangh

This comment has been minimized.

Copy link
Contributor

rgolangh commented Apr 14, 2019

+1 for roles/openshift_ovirt. Can you add playbooks/ovirt as well?

@ingvagabund

This comment has been minimized.

Copy link
Member

ingvagabund commented Apr 15, 2019

Hey @mtnbikenc :), I am already to far from the current state of the openshift-ansible that my reviews of the components where I am as an owner would hurt more than help :). Can you please remove me from the owners?

Also, both @aveshagarwal and @wozniakjan have left the company.

@mtnbikenc mtnbikenc force-pushed the mtnbikenc:release-3.11-owners branch from 13fcaef to 13f610f Apr 18, 2019

@mtnbikenc

This comment has been minimized.

Copy link
Member Author

mtnbikenc commented Apr 18, 2019

Squashed and rebased.

@mtnbikenc mtnbikenc changed the title OWNERS File Audit [release-3.11] OWNERS File Audit Apr 18, 2019

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Apr 18, 2019

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-crio 13f610f link /test e2e-gcp-crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson merged commit 1518e94 into openshift:release-3.11 Apr 18, 2019

7 of 9 checks passed

ci/prow/e2e-gcp-crio Job failed.
Details
tide Not mergeable. Needs lgtm label.
Details
ci/openshift-jenkins/logging Jenkins job succeeded.
Details
ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-gcp Job succeeded.
Details
ci/prow/gcp-major-upgrade Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtnbikenc mtnbikenc deleted the mtnbikenc:release-3.11-owners branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.