Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.9] Workaround missing network metrics when using cri-o #11610

Merged
merged 1 commit into from May 29, 2019
Merged

[release-3.9] Workaround missing network metrics when using cri-o #11610

merged 1 commit into from May 29, 2019

Conversation

jcpowermac
Copy link
Contributor

Adds openshift-node service restart after metrics is installed.

Bug 1649984 - https://bugzilla.redhat.com/show_bug.cgi?id=1649984

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2019
@mtnbikenc
Copy link
Member

/hold
Need to address serial drain of nodes before restarts.

Backports #11607

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2019
@jcpowermac
Workaround missing network metrics when using cri-o
1d55e2a 
Adds node drain
Adds openshift-node service restart after metrics is installed.
@jcpowermac
Copy link
Contributor Author

@mtnbikenc updated for drain and retested.

mtnbikenc
mtnbikenc approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jcpowermac,mtnbikenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit deb7dcc into openshift:release-3.9 May 29, 2019
@jcpowermac jcpowermac deleted the cp-11607 branch June 27, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@mtnbikenc mtnbikenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcpowermac @mtnbikenc @openshift-ci-robot @openshift-merge-robot