New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds current registry route hostname when generating the new certs #11752
Adds current registry route hostname when generating the new certs #11752
Conversation
Hi @jtudelag. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…erts. There are situations when docker-registry hostname is not "docker-registry-default." + {{ openshift_master_default_subdomain }}. For example when a customer wants to give the Registry a prettier name, or when using Router sharding, labelling the default NS, and using a different subdomain than the default one.
a24f522
to
8797636
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtudelag, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/retest Please review the full test history for this PR and help us cut down flakes. |
There are situations when docker-registry hostname is not "docker-registry-default." + {{ openshift_master_default_subdomain }}.
For example when a customer wants to give the Registry a prettier name, or when using Router sharding, labelling the default NS, and using a different subdomain than the default one.
The redeploy registry certs playbooks does not take that into account, so It will never add the current docker-registry route hostname to the certificates..
This PR fix that,