New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard check for container install based on openshift dictionary key #4384

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
4 participants
@admiyo

admiyo commented Jun 7, 2017

No description provided.

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
Member

openshift-bot commented Jun 7, 2017

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
Member

openshift-bot commented Jun 7, 2017

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
@sdodson

sdodson approved these changes Jun 7, 2017

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Jun 7, 2017

Member

bot, test pull request

Member

sdodson commented Jun 7, 2017

bot, test pull request

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Jun 7, 2017

Member

@abutcher I guess this is necessary because it's run across host group and we may hit another node that hasn't had facts collected?

Member

sdodson commented Jun 7, 2017

@abutcher I guess this is necessary because it's run across host group and we may hit another node that hasn't had facts collected?

@admiyo

This comment has been minimized.

Show comment
Hide comment
@admiyo

admiyo Jun 7, 2017

Yes, I was seeing this when running on a two node cluster. Without this change, the expresssion was erroring out with an error indicating that the openshift dictionary had not been created.

admiyo commented Jun 7, 2017

Yes, I was seeing this when running on a two node cluster. Without this change, the expresssion was erroring out with an error indicating that the openshift dictionary had not been created.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Jun 7, 2017

Member

aos-ci-test

Member

sdodson commented Jun 7, 2017

aos-ci-test

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 58a69b0 (logs)

Member

openshift-bot commented Jun 7, 2017

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 58a69b0 (logs)

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 58a69b0 (logs)

Member

openshift-bot commented Jun 7, 2017

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 58a69b0 (logs)

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 58a69b0 (logs)

Member

openshift-bot commented Jun 7, 2017

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 58a69b0 (logs)

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 58a69b0 (logs)

Member

openshift-bot commented Jun 7, 2017

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 58a69b0 (logs)

@abutcher

This comment has been minimized.

Show comment
Hide comment
@abutcher

abutcher Jun 7, 2017

Member

bot, retest this please

Member

abutcher commented Jun 7, 2017

bot, retest this please

@abutcher

This comment has been minimized.

Show comment
Hide comment
@abutcher

abutcher Jun 7, 2017

Member

@sdodson Right, I can see this being a problem if one of the hosts were unavailable or had received a previous error. We collect facts for all oo_nodes_to_config in the play prior to the changes so I would expect facts to be set.

Member

abutcher commented Jun 7, 2017

@sdodson Right, I can see this being a problem if one of the hosts were unavailable or had received a previous error. We collect facts for all oo_nodes_to_config in the play prior to the changes so I would expect facts to be set.

@abutcher

This comment has been minimized.

Show comment
Hide comment
@abutcher

abutcher Jun 7, 2017

Member

[merge]

Member

abutcher commented Jun 7, 2017

[merge]

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

Evaluated for openshift ansible merge up to 58a69b0

Member

openshift-bot commented Jun 7, 2017

Evaluated for openshift ansible merge up to 58a69b0

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

[test]ing while waiting on the merge queue

Member

openshift-bot commented Jun 7, 2017

[test]ing while waiting on the merge queue

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

Evaluated for openshift ansible test up to 58a69b0

Member

openshift-bot commented Jun 7, 2017

Evaluated for openshift ansible test up to 58a69b0

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 7, 2017

Member

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/188/) (Base Commit: f510d55)

Member

openshift-bot commented Jun 7, 2017

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/188/) (Base Commit: f510d55)

@openshift-bot

This comment has been minimized.

Show comment
Hide comment
@openshift-bot

openshift-bot Jun 8, 2017

Member

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/526/) (Base Commit: bbddb25)

Member

openshift-bot commented Jun 8, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/526/) (Base Commit: bbddb25)

@openshift-bot openshift-bot merged commit 3662056 into openshift:master Jun 8, 2017

13 of 14 checks passed

aos-ci-jenkins/all Internal Jenkins error during provisioning the jenkins slave.
Details
aos-ci-jenkins/OS_3.5_NOT_containerized "openshift-ansible install passed"
Details
aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests "e2e tests passed"
Details
aos-ci-jenkins/OS_3.5_containerized "openshift-ansible install passed"
Details
aos-ci-jenkins/OS_3.5_containerized_e2e_tests "e2e tests passed"
Details
aos-ci-jenkins/OS_3.6_NOT_containerized "openshift-ansible install passed"
Details
aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests "e2e tests passed"
Details
aos-ci-jenkins/OS_3.6_containerized "openshift-ansible install passed"
Details
aos-ci-jenkins/OS_3.6_containerized_e2e_tests "e2e tests passed"
Details
continuous-integration/openshift-jenkins/merge Passed
continuous-integration/openshift-jenkins/test Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 53.033%
Details
fedora/25/atomic | origin/v3.6.0-alpha.1 All tests passed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment