use the storage path for logging from facts #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aos-ci-test |
|
@jcantrill im not following, how does this resolve that? what does the |
|
The logging facts are separated between ops and non ops. The filter offers
a root from which to evaluate storage and it defaults to the value to read
non ops. My understanding is the value for ops was getting wiped out
because it was inspecting the wrong fact
On Fri, Jun 30, 2017 at 4:44 PM Eric Wolinetz ***@***.***> wrote:
@jcantrill <https://github.com/jcantrill> im not following, how does this
resolve that? what does the es_fact_root do for that filter plugin?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4661 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEVnONAheI3-TbESE9jxTMBZgBbBaHDoks5sJV4vgaJpZM4OK6Vy>
.
--
--
Jeff Cantrill
Senior Software Engineer, Red Hat Engineering
OpenShift Integration Services
Red Hat, Inc.
*Office*: 703-748-4420 | 866-546-8970 ext. 8162420
jcantril@redhat.com
http://www.redhat.com
|
|
@ewolinetz feel free to merge if you're +1 on this, the bot won't work on this branch. |
ewolinetz
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1466695 in 1.5 where hostpath was not being honored for the ops deployment. There is no equivalent logic in master but I wonder if its a 'WONTFIX'. Shouldn't we be encouraging users to update their inventory to match the state they desire? @sdodson ??