Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds null nodeselector when creating logging project #4746

Closed
wants to merge 1 commit into from

Conversation

thoraxe
Copy link

@thoraxe thoraxe commented Jul 12, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1470394

For whatever reason, when the logging project doesn't already exist and you are running the logging installation against an existing cluster where there is a default node selector for projects, the logging install blows up.

This change adds a null nodeselector to the project creation line.

I'm not sure there's a "better" implementation here.

@ewolinetz
Copy link
Contributor

@thoraxe looking at the bz, that is open against 3.5 correct? this fix should be based on the release-1.5 branch (I also believe it would be contained within the openshift_logging role and not openshift_hosted_logging role)

@thoraxe
Copy link
Author

thoraxe commented Jul 12, 2017

@ewolinetz The BZ is filed against 3.5 but this affects any OpenShift environment -- I don't believe nodeselector logic has changed, as it's core Kube stuff.

Are you saying that you want me to check out release-1.5 and then make my fix to that and PR back to release-1.5?

@thoraxe thoraxe closed this Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants