New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1467265 - logging: add 'purge' option with uninstall #5189
Bug 1467265 - logging: add 'purge' option with uninstall #5189
Conversation
|
aos-ci-test |
|
@wozniakjan The situation from which this originated, is it necessary for us to backport this to 3.6? |
The common uninstall would keep PVC around to prevent unwanted data loss during reinstalls. There is a scenario where the user may want complete removal of EFK stack including PVC. This change adds an optional `openshift_logging_purge_logging` variable to completely remove the EFK stack. By default, this is set to 'False' and only works if user sets `openshift_logging_install_logging` to 'False' to initiate the uninstallation process.
63c3a06
to
51a2d9d
Compare
|
@jcantrill I don't think it is necessary to backport but it can be backported without breaking any backward compatibility. However, I consider this to be a new functionality to completely remove the logging and it should be probably properly documented so I would rather see it introduced in the following minor release Maybe @ruromero could weigh in as a reporter of that BZ |
|
I would prefer not to backport if we do not need to.
|
|
aos-ci-test |
|
[merge] |
|
[test]ing while waiting on the merge queue |
|
Evaluated for openshift ansible test up to 51a2d9d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/540/) (Base Commit: cc47755) (PR Branch Commit: 51a2d9d) |
|
[merge]
--
--
Jeff Cantrill
Senior Software Engineer, Red Hat Engineering
OpenShift Integration Services
Red Hat, Inc.
*Office*: 703-748-4420 | 866-546-8970 ext. 8162420
jcantril@redhat.com
http://www.redhat.com
|
|
Evaluated for openshift ansible merge up to 51a2d9d |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/922/) (Base Commit: f778b5d) (PR Branch Commit: 51a2d9d) |
|
aos-ci-test |
The common uninstall would keep PVC around to prevent unwanted data loss during reinstalls. There is a scenario where the user may want complete removal of EFK stack including PVC.
This change adds an optional
openshift_logging_purge_loggingvariable to completely remove the EFK stack. By default, this is set to 'False' and only works if user setsopenshift_logging_install_loggingto 'False' to initiate the uninstallation process.cc: @jcantrill , @richm
https://bugzilla.redhat.com/show_bug.cgi?id=1467265