Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1467265 - logging: add 'purge' option with uninstall #5189

Merged
merged 1 commit into from Aug 31, 2017

Conversation

wozniakjan
Copy link
Contributor

@wozniakjan wozniakjan commented Aug 24, 2017

The common uninstall would keep PVC around to prevent unwanted data loss during reinstalls. There is a scenario where the user may want complete removal of EFK stack including PVC.

This change adds an optional openshift_logging_purge_logging variable to completely remove the EFK stack. By default, this is set to 'False' and only works if user sets openshift_logging_install_logging to 'False' to initiate the uninstallation process.

cc: @jcantrill , @richm

https://bugzilla.redhat.com/show_bug.cgi?id=1467265

@jcantrill
Copy link
Contributor

aos-ci-test

@jcantrill
Copy link
Contributor

@wozniakjan The situation from which this originated, is it necessary for us to backport this to 3.6?

The common uninstall would keep PVC around to prevent unwanted data loss during
reinstalls. There is a scenario where the user may want complete removal of EFK
stack including PVC.

This change adds an optional `openshift_logging_purge_logging` variable to
completely remove the EFK stack. By default, this is set to 'False' and only
works if user sets `openshift_logging_install_logging` to 'False' to initiate
the uninstallation process.
@wozniakjan
Copy link
Contributor Author

@jcantrill I don't think it is necessary to backport but it can be backported without breaking any backward compatibility. However, I consider this to be a new functionality to completely remove the logging and it should be probably properly documented so I would rather see it introduced in the following minor release

Maybe @ruromero could weigh in as a reporter of that BZ

@jcantrill
Copy link
Contributor

jcantrill commented Aug 24, 2017 via email

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 63c3a06 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 63c3a06 (logs)

@sdodson
Copy link
Member

sdodson commented Aug 24, 2017

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 51a2d9d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 51a2d9d (logs)

@jcantrill
Copy link
Contributor

[merge]

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 51a2d9d

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/540/) (Base Commit: cc47755) (PR Branch Commit: 51a2d9d)

@jcantrill
Copy link
Contributor

jcantrill commented Aug 26, 2017 via email

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 51a2d9d

@openshift-bot
Copy link

openshift-bot commented Aug 26, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/922/) (Base Commit: f778b5d) (PR Branch Commit: 51a2d9d)

@wozniakjan
Copy link
Contributor Author

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 51a2d9d (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 51a2d9d (logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants