Don't assume storage_migration control variables are already boolean #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift_upgrade_pre_storage_migration_enabled openshift_upgrade_pre_storage_migration_fatal openshift_upgrade_post_storage_migration_enabled openshift_upgrade_post_storage_migration_enabled because the 4 variables are not already defaulted/evaluated there's no guarantee that they're actually the boolean type at this point. Example: if they're passed in on the command line
openshift-ci-robot
added
the
size/S
sdodson
approved these changes
Sep 13, 2017
|
aos-ci-test |
|
[test] |
|
Evaluated for openshift ansible test up to d9ceaf4 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/663/) (Base Commit: a0086cb) (PR Branch Commit: d9ceaf4) |
|
@sdodson I can't follow the cause of the breakage in the tests (or even what's actually broken...) Is this breakage from my PR or just a flakey test? |
|
aos-ci-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift_upgrade_pre_storage_migration_enabled
openshift_upgrade_pre_storage_migration_fatal
openshift_upgrade_post_storage_migration_enabled
openshift_upgrade_post_storage_migration_enabled
because the 4 variables are not already defaulted/evaluated there's no
guarantee that they're actually the boolean type at this point.
Example: if they're passed in on the command line