New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure controllerConfig.serviceServingCert is correctly set during upgrade. #5765

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
4 participants
@abutcher
Member

abutcher commented Oct 13, 2017

A typo was originally introduced in #2449 causing an incorrect key to be configured within the master config. This commit ensures that the correct key is set during upgrades.

/cc @dlbewley
https://bugzilla.redhat.com/show_bug.cgi?id=1500981

@abutcher abutcher requested a review from sdodson Oct 13, 2017

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Oct 13, 2017

@abutcher: GitHub didn't allow me to request PR reviews from the following users: dlbewley.

Note that only openshift members can review this PR, and authors cannot review their own PRs.

In response to this:

A typo was originally introduced in #2449 causing an incorrect key to be configured within the master config. This commit ensures that the correct key is set during upgrades.

/cc @dlbewley
https://bugzilla.redhat.com/show_bug.cgi?id=1500981

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot commented Oct 13, 2017

@abutcher: GitHub didn't allow me to request PR reviews from the following users: dlbewley.

Note that only openshift members can review this PR, and authors cannot review their own PRs.

In response to this:

A typo was originally introduced in #2449 causing an incorrect key to be configured within the master config. This commit ensures that the correct key is set during upgrades.

/cc @dlbewley
https://bugzilla.redhat.com/show_bug.cgi?id=1500981

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Oct 16, 2017

Member

/retest

Member

sdodson commented Oct 16, 2017

/retest

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Oct 16, 2017

Member

/lgtm

Member

sdodson commented Oct 16, 2017

/lgtm

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Oct 17, 2017

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

openshift-merge-robot commented Oct 17, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Oct 17, 2017

Contributor

Automatic merge from submit-queue.

Contributor

openshift-merge-robot commented Oct 17, 2017

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 7908efc into openshift:master Oct 17, 2017

8 of 9 checks passed

Submit Queue Required Github CI test is not green: ci/openshift-jenkins/upgrade
Details
ci/openshift-jenkins/containerized Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/logging Jenkins job succeeded.
Details
ci/openshift-jenkins/system-containers Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
ci/openshift-jenkins/upgrade Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fedora/26/atomic All tests passed.
Details

@abutcher abutcher deleted the abutcher:service-serving-cert-typo branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment