New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing docker crio installation. #6105

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
7 participants
@kwoodson
Member

kwoodson commented Nov 13, 2017

This is the correct check for whether the docker storage is a symlink.

Not sure how this squeaked through. We will need this in 3.7 for CRI-O.

@kwoodson kwoodson requested a review from ashcrow Nov 13, 2017

@kwoodson kwoodson self-assigned this Nov 13, 2017

@kwoodson kwoodson requested a review from sdodson Nov 13, 2017

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Nov 13, 2017

Member

@ashcrow, maybe we should remove the is defined check?

Member

kwoodson commented Nov 13, 2017

@ashcrow, maybe we should remove the is defined check?

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Nov 14, 2017

Member

@ashcrow, this latest patch has been verified. I think what happened before is that I deployed onto an older AMI and verified the symlink was there. I cannot say for sure but I think we need to back port this change to 3.7.

Member

kwoodson commented Nov 14, 2017

@ashcrow, this latest patch has been verified. I think what happened before is that I deployed onto an older AMI and verified the symlink was there. I cannot say for sure but I think we need to back port this change to 3.7.

@kargakis

This comment has been minimized.

Show comment
Hide comment
@kargakis

kargakis Nov 14, 2017

Member

/cherrypick release-3.7

Member

kargakis commented Nov 14, 2017

/cherrypick release-3.7

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Nov 14, 2017

@kargakis: @kargakis once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Nov 14, 2017

@kargakis: @kargakis once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Nov 14, 2017

Member

/retest

Member

sdodson commented Nov 14, 2017

/retest

@ashcrow

Wow, islnk is a terrible trick on the eyes!

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Nov 14, 2017

Member

/test install

Member

ashcrow commented Nov 14, 2017

/test install

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Nov 14, 2017

Member

/lgtm

Member

sdodson commented Nov 14, 2017

/lgtm

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Nov 14, 2017

Member

bot, retest this please

Member

ashcrow commented Nov 14, 2017

bot, retest this please

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Nov 15, 2017

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

openshift-merge-robot commented Nov 15, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Nov 15, 2017

Member

/test install

Member

kwoodson commented Nov 15, 2017

/test install

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Nov 15, 2017

Member

/test upgrade

Member

kwoodson commented Nov 15, 2017

/test upgrade

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Nov 15, 2017

Member

@sdodson, what's the plan with this one? I thought upgrade wasn't a blocker.

Member

kwoodson commented Nov 15, 2017

@sdodson, what's the plan with this one? I thought upgrade wasn't a blocker.

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Nov 15, 2017

@kwoodson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade a322f1f link /test upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot commented Nov 15, 2017

@kwoodson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade a322f1f link /test upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Nov 15, 2017

Member

Yeah, that shouldn't block the merge, it's still in the queue. Given the nature of this change i'm just going to merge this.

Member

sdodson commented Nov 15, 2017

Yeah, that shouldn't block the merge, it's still in the queue. Given the nature of this change i'm just going to merge this.

@sdodson sdodson merged commit 763f604 into openshift:master Nov 15, 2017

7 of 9 checks passed

ci/openshift-jenkins/upgrade Jenkins job failed.
Details
fedora/26/atomic Test failed with rc 2.
Details
Submit Queue Queued to run github e2e tests a second time.
Details
ci/openshift-jenkins/containerized Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/logging Jenkins job succeeded.
Details
ci/openshift-jenkins/system-containers Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Nov 15, 2017

@kargakis: New pull request created: #6130

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Nov 15, 2017

@kargakis: New pull request created: #6130

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson added a commit that referenced this pull request Nov 15, 2017

Merge pull request #6130 from openshift-cherrypick-robot/cherry-pick-…
…6105-to-release-3.7

Automated cherry-pick of #6105 on release-3.7

@kwoodson kwoodson deleted the kwoodson:docker_crio_fix branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment