Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
syscontainers: fix CRI-O and container-engine installation #6316
if you are already addressing this issue in your PR, I am fine to close this one. I don't want to create merge conflicts for such a trivial change :-)
The only reason I've opened this PR is that the installation was failing for me, as
We can implement this PR as long as we don't include container_runtime as meta to openshift_version.
Yes, prerequisites is now part of the CI jobs for everything that had 'install origin' as a step. I added some logic to openshift_version to skip it during prerequisites as those steps shouldn't be version dependent.
My latest patch has container_runtime role going to include_role with an empty main.yml, so the only that would be shared even if we did implement this here are the default role variables.
We have discussed previously reducing the scope of openshift-version, so I'm interested to know what pieces here are blocking for crio and system containers so we can patch those more properly.
Dec 8, 2017
0 of 9 checks passed
referenced this pull request
Dec 8, 2017
@giuseppe: The following test failed, say