New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ami building. #6373

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
5 participants
@kwoodson
Member

kwoodson commented Dec 6, 2017

With the recent refactors and moving the docker role to the container_runtime this has broken the AMI building process. The changes here calls the prerequisites in order to get the correct runtime installed.

@kwoodson kwoodson requested a review from mtnbikenc Dec 6, 2017

@kwoodson kwoodson self-assigned this Dec 6, 2017

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Dec 6, 2017

Member

/test system-containers

Member

ashcrow commented Dec 6, 2017

/test system-containers

@mtnbikenc

I see a pattern emerging here with skip_* where we need init but we don't want it all. We should discuss how we can better handle init as a whole.
/lgtm

@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Dec 6, 2017

Member

Unrelated error.

        "time=\"2017-12-06T16:21:57Z\" level=fatal msg=\"Error initializing image from source docker://registry.fedoraproject.org/f26/etcd:latest: manifest unknown: manifest unknown\" "
Member

kwoodson commented Dec 6, 2017

Unrelated error.

        "time=\"2017-12-06T16:21:57Z\" level=fatal msg=\"Error initializing image from source docker://registry.fedoraproject.org/f26/etcd:latest: manifest unknown: manifest unknown\" "
@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Dec 6, 2017

Member

/test system-containers

Member

kwoodson commented Dec 6, 2017

/test system-containers

@kwoodson kwoodson merged commit 2124109 into openshift:master Dec 7, 2017

6 of 8 checks passed

fedora/27/atomic Could not pull image 'registry.fedoraproject.org/fedora:27'.
Submit Queue Required Github CI test is not green: fedora/27/atomic
Details
ci/openshift-jenkins/containerized Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/logging Jenkins job succeeded.
Details
ci/openshift-jenkins/system-containers Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kwoodson

This comment has been minimized.

Show comment
Hide comment
@kwoodson

kwoodson Dec 12, 2017

Member

/cherrypick release-3.8

Member

kwoodson commented Dec 12, 2017

/cherrypick release-3.8

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Dec 12, 2017

@kwoodson: new pull request created: #6446

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Dec 12, 2017

@kwoodson: new pull request created: #6446

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwoodson kwoodson deleted the kwoodson:ami_build_container_runtime branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment