New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode the network interface in the openshift_logging_mux role #6609

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
10 participants
@nkinder
Contributor

nkinder commented Jan 4, 2018

The openshift_logging_mux role hardcodes the 'eth0' interface alias
for determining the IP address to use for incoming external client
connections. This will cause the playbook to fail with an undefined
variable error on systems where an 'eth0' interface does not exist.

This patch changes the default IP address for external connections
to use the 'ansible_default_ipv4' fact. It also allows this to be
overridden by a new 'openshift_logging_mux_external_address' variable.

Don't hardcode the network interface in the openshift_logging_mux role
The openshift_logging_mux role hardcodes the 'eth0' interface alias
for determining the IP address to use for incoming external client
connections.  This will cause the playbook to fail with an undefined
variable error on systems where an 'eth0' interface does not exist.

This patch changes the default IP address for external connections
to use the 'ansible_default_ipv4' fact.  It also allows this to be
overridden by a new 'openshift_logging_mux_external_address' variable.
@rh-atomic-bot

This comment has been minimized.

Show comment
Hide comment
@rh-atomic-bot

rh-atomic-bot Jan 4, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

rh-atomic-bot commented Jan 4, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 4, 2018

Contributor

/ok-to-test

Contributor

ewolinetz commented Jan 4, 2018

/ok-to-test

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 4, 2018

Contributor

bot, test pull request

Contributor

ewolinetz commented Jan 4, 2018

bot, test pull request

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 4, 2018

Contributor

@sdodson will ansible_default_ipv4 always be defined by the time we get to the logging playbook?

Contributor

ewolinetz commented Jan 4, 2018

@sdodson will ansible_default_ipv4 always be defined by the time we get to the logging playbook?

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Jan 4, 2018

Member

@sdodson will ansible_default_ipv4 always be defined by the time we get to the logging playbook?

The only situation where it wouldn't be is if the host has no default interface, this is a built in ansible fact so it gets set the first time facts are gathered.

Member

sdodson commented Jan 4, 2018

@sdodson will ansible_default_ipv4 always be defined by the time we get to the logging playbook?

The only situation where it wouldn't be is if the host has no default interface, this is a built in ansible fact so it gets set the first time facts are gathered.

@nkinder

This comment has been minimized.

Show comment
Hide comment
@nkinder

nkinder Jan 5, 2018

Contributor

/retest

Contributor

nkinder commented Jan 5, 2018

/retest

1 similar comment
@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 5, 2018

Contributor

/retest

Contributor

ewolinetz commented Jan 5, 2018

/retest

@nkinder

This comment has been minimized.

Show comment
Hide comment
@nkinder

nkinder Jan 5, 2018

Contributor

/cherrypick release-3.8

Contributor

nkinder commented Jan 5, 2018

/cherrypick release-3.8

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 5, 2018

@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 5, 2018

@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nkinder

This comment has been minimized.

Show comment
Hide comment
@nkinder

nkinder Jan 5, 2018

Contributor

/cherrypick release-3.7

Contributor

nkinder commented Jan 5, 2018

/cherrypick release-3.7

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 5, 2018

@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 5, 2018

@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 5, 2018

Contributor

/cherrypick release-3.7

Contributor

ewolinetz commented Jan 5, 2018

/cherrypick release-3.7

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 5, 2018

@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 5, 2018

@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 5, 2018

Contributor

/cherrypick release-3.8

Contributor

ewolinetz commented Jan 5, 2018

/cherrypick release-3.8

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 5, 2018

@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 5, 2018

@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 5, 2018

Contributor

conformance test error openshift/origin#17634
/retest

Contributor

ewolinetz commented Jan 5, 2018

conformance test error openshift/origin#17634
/retest

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 8, 2018

Contributor

/retest

Contributor

ewolinetz commented Jan 8, 2018

/retest

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 8, 2018

Contributor

bot, retest this please

Contributor

ewolinetz commented Jan 8, 2018

bot, retest this please

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 8, 2018

Contributor

/lgtm

Contributor

ewolinetz commented Jan 8, 2018

/lgtm

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 9, 2018

Contributor

bot, test pull request

Contributor

ewolinetz commented Jan 9, 2018

bot, test pull request

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 9, 2018

Member

bot, retest this please

Member

ashcrow commented Jan 9, 2018

bot, retest this please

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 9, 2018

Member

@jlebon PTAL. Looks like the bot is not running for this specific PR yet it's blocking the ability to merge (as it should).

Member

ashcrow commented Jan 9, 2018

@jlebon PTAL. Looks like the bot is not running for this specific PR yet it's blocking the ability to merge (as it should).

@cgwalters

This comment has been minimized.

Show comment
Hide comment
@cgwalters

cgwalters Jan 9, 2018

Contributor

FWIW I looked through the internal CI execution queue and don't see it; debugging this stuff is a huge pain since there's many legs in the chain that can go wrong in bridging the webhooks to fedmsg to the internal message bus to the internal jenkins.

Contributor

cgwalters commented Jan 9, 2018

FWIW I looked through the internal CI execution queue and don't see it; debugging this stuff is a huge pain since there's many legs in the chain that can go wrong in bridging the webhooks to fedmsg to the internal message bus to the internal jenkins.

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 9, 2018

Member

@cgwalters thanks for taking a look.

@sdodson this seems to be an outlier in that fedmsg or another piece of infra flaked and so it's not showing up. If you're OK with it I suggest the force merge as PRs before and after this are being tested as they should be with the atomic bot.

Member

ashcrow commented Jan 9, 2018

@cgwalters thanks for taking a look.

@sdodson this seems to be an outlier in that fedmsg or another piece of infra flaked and so it's not showing up. If you're OK with it I suggest the force merge as PRs before and after this are being tested as they should be with the atomic bot.

@cgwalters

This comment has been minimized.

Show comment
Hide comment
@cgwalters

cgwalters Jan 9, 2018

Contributor

bot, retest this please

Contributor

cgwalters commented Jan 9, 2018

bot, retest this please

@jlebon

This comment has been minimized.

Show comment
Hide comment
@jlebon

jlebon Jan 9, 2018

Member

I think this may be because @nkinder is not in the openshift or projectatomic org, which automatically whitelists all members.

Member

jlebon commented Jan 9, 2018

I think this may be because @nkinder is not in the openshift or projectatomic org, which automatically whitelists all members.

@jlebon

This comment has been minimized.

Show comment
Hide comment
@jlebon

jlebon Jan 9, 2018

Member

bot, add author to whitelist

Member

jlebon commented Jan 9, 2018

bot, add author to whitelist

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 9, 2018

Member

@jlebon @ewolinetz already tried whitelisting and asking to retest.

Member

ashcrow commented Jan 9, 2018

@jlebon @ewolinetz already tried whitelisting and asking to retest.

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Jan 10, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

openshift-merge-robot commented Jan 10, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 10, 2018

Contributor

/retest

Contributor

ewolinetz commented Jan 10, 2018

/retest

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 10, 2018

Member

@jlebon out of curiosity what changed? The bot's happy now but I don't see anything different via the comments.

Member

ashcrow commented Jan 10, 2018

@jlebon out of curiosity what changed? The bot's happy now but I don't see anything different via the comments.

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Jan 10, 2018

Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

Contributor

openshift-merge-robot commented Jan 10, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-merge-robot

openshift-merge-robot Jan 10, 2018

Contributor

Automatic merge from submit-queue.

Contributor

openshift-merge-robot commented Jan 10, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 14e5e8c into openshift:master Jan 10, 2018

6 of 9 checks passed

Submit Queue Required Github CI test is not green: ci/openshift-jenkins/install
Details
ci/openshift-jenkins/extended_conformance_install_crio Jenkins job running.
Details
ci/openshift-jenkins/logging Jenkins job running.
Details
ci/openshift-jenkins/containerized Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/system-containers Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fedora/27/atomic All tests passed.
Details
@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 10, 2018

@nkinder: new pull request created: #6689

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 10, 2018

@nkinder: new pull request created: #6689

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz

This comment has been minimized.

Show comment
Hide comment
@ewolinetz

ewolinetz Jan 10, 2018

Contributor

/cherrypick release-3.7

Contributor

ewolinetz commented Jan 10, 2018

/cherrypick release-3.7

@openshift-cherrypick-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-cherrypick-robot

openshift-cherrypick-robot Jan 10, 2018

@ewolinetz: new pull request created: #6690

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot commented Jan 10, 2018

@ewolinetz: new pull request created: #6690

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

This comment has been minimized.

Show comment
Hide comment
@openshift-ci-robot

openshift-ci-robot Jan 10, 2018

@nkinder: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 3c5539a link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot commented Jan 10, 2018

@nkinder: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 3c5539a link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment