New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for firewalld on atomic host #6763

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
5 participants
@sdodson
Member

sdodson commented Jan 17, 2018

Right now this is only available on fedora so guard it with
openshift_enable_unsupported_configurations

@sdodson sdodson force-pushed the sdodson:allow-firewalld-with-override branch from de6668b to 1fca358 Jan 17, 2018

@sdodson sdodson changed the title from Allow for firewalld on atomic host to WIP Allow for firewalld on atomic host Jan 18, 2018

@vrutkovs

The next task - "Install firewalld packages" - should be skipped to avoid an attempt to install packages on Atomic host

Allow for firewalld on atomic host
Right now this is only available on fedora so guard it with
openshift_enable_unsupported_configurations

@sdodson sdodson force-pushed the sdodson:allow-firewalld-with-override branch from 1fca358 to 4671dcc Jan 18, 2018

@sdodson

This comment has been minimized.

Member

sdodson commented Jan 18, 2018

@vrutkovs thanks, updated.

@vrutkovs

This comment has been minimized.

Contributor

vrutkovs commented Jan 18, 2018

Looks good to me, but latest Fedora Atomic 27 doesn't seem to have firewalld and python bindings installed yet

@sdodson

This comment has been minimized.

Member

sdodson commented Jan 18, 2018

@dustymabe Do we get firewalld python bindings with your changes?

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Jan 18, 2018

@vrutkovs
Looks good to me, but latest Fedora Atomic 27 doesn't seem to have firewalld and python bindings installed yet

we have a new release going out today. I'll post back here when that is officially released.

@sdodson
@dustymabe Do we get firewalld python bindings with your changes?

yes, we get python3 firewalld bindings. For fedora atomic I've only been running the installer using python3 for some time now so I assume that is reasonable.

@dustymabe

This comment has been minimized.

@dustymabe

This comment has been minimized.

Contributor

dustymabe commented Jan 18, 2018

@sdodson - tested this change (backported to the 3.7 branch) and it seems to work with

os_firewall_use_firewalld=true                                                                                                                                                                                                              
openshift_enable_unsupported_configurations=true

👍

@vrutkovs

/lgtm

worked fine on newer Fedora Atomic

@sdodson sdodson changed the title from WIP Allow for firewalld on atomic host to Allow for firewalld on atomic host Jan 19, 2018

@sdodson

This comment has been minimized.

Member

sdodson commented Jan 19, 2018

We'll drop the unsupported guard as soon as we ship a RHEL AH with this change as well.

@openshift-merge-robot

This comment has been minimized.

Contributor

openshift-merge-robot commented Jan 19, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot

This comment has been minimized.

Contributor

openshift-merge-robot commented Jan 19, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit c889d5f into openshift:master Jan 19, 2018

5 of 8 checks passed

Submit Queue Required Github CI test is not green: ci/openshift-jenkins/install
Details
ci/openshift-jenkins/extended_conformance_install_crio Jenkins job running.
Details
ci/openshift-jenkins/logging Jenkins job running.
Details
ci/openshift-jenkins/containerized Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/system-containers Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@openshift-ci-robot

This comment has been minimized.

openshift-ci-robot commented Jan 20, 2018

@sdodson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging 4671dcc link /test logging
ci/openshift-jenkins/extended_conformance_install_crio 4671dcc link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment