Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default of openshift_logging_public_master_url to use opensh… #7260

Merged

Conversation

ewolinetz
Copy link
Contributor

…ift_master_cluster_public_hostname if available

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1547944

Leaving openshift.common.public_hostname as there isn't a openshift.master.public_hostname always.

…ift_master_cluster_public_hostname if available
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2018
@jcantrill
Copy link
Contributor

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

/retest

@ewolinetz
Copy link
Contributor Author

/test install

@sdodson
Copy link
Member

sdodson commented Feb 23, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit ead9d0e into openshift:master Feb 24, 2018
@openshift-ci-robot
Copy link

@ewolinetz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/system-containers 3349f8c link /test system-containers
ci/openshift-jenkins/extended_conformance_install_crio 3349f8c link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ewolinetz
Copy link
Contributor Author

/cherrypick release-3.7

@openshift-cherrypick-robot

@ewolinetz: new pull request created: #7279

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz ewolinetz deleted the ha_kibana_defaults branch February 24, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_3.7 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants