Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] Adding check in case only one ES container is in the pod for upgrades to 3.7 #7546

Merged
merged 1 commit into from Mar 21, 2018
Merged

[3.7] Adding check in case only one ES container is in the pod for upgrades to 3.7 #7546

merged 1 commit into from Mar 21, 2018

Conversation

ewolinetz
Copy link
Contributor

Addresses upgrades from 3.6 where we only had one container in the ES pod to 3.7 where we have two.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1557044

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 15, 2018
jcantrill
jcantrill approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2018
@jcantrill
Copy link
Contributor

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

/retest

@mtnbikenc mtnbikenc changed the title Adding check in case only one ES container is in the pod for upgrades to 3.7 [3.7] Adding check in case only one ES container is in the pod for upgrades to 3.7 Mar 19, 2018
mtnbikenc
mtnbikenc approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mtnbikenc
Copy link
Member

/retest

michaelgugino
michaelgugino suggested changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear what's happening here or why. Some comments would be very helpful.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2018
@ewolinetz
Copy link
Contributor Author

@michaelgugino added comments

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2018
michaelgugino
michaelgugino approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the comments, that adds a lot of clarification to those actions.

@ewolinetz
Copy link
Contributor Author

tox errors seem to not be related to changes in this PR at all...
I'm not sure if this needs to be manually merged at all

@mtnbikenc
Copy link
Member

I've got a tox fix in this commit, but we might need to pull that out and manually merge it to fix the queue.
c24ae1c

@mtnbikenc
Copy link
Member

Tox fix: #7571

@mtnbikenc
Copy link
Member

/test tox

1 similar comment
@ewolinetz
Copy link
Contributor Author

/test tox

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2018 •
edited

@ewolinetz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/containerized 467b036 link /test containerized
ci/openshift-jenkins/system-containers 467b036 link /test system-containers
ci/openshift-jenkins/gcp 467b036 link /test gcp
ci/openshift-jenkins/extended_conformance_install_crio 467b036 link /test crio
ci/openshift-jenkins/install 467b036 link /test install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ewolinetz
Copy link
Contributor Author

/test tox

@sdodson sdodson merged commit 4da04fd into openshift:release-3.7 Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill approved these changes

@michaelgugino michaelgugino michaelgugino approved these changes

@mtnbikenc mtnbikenc mtnbikenc approved these changes

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@jcantrill jcantrill

@michaelgugino michaelgugino

@mtnbikenc mtnbikenc

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ewolinetz @jcantrill @mtnbikenc @openshift-ci-robot @michaelgugino @sdodson