Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openshift_facts migrated_facts #8291

Conversation

@michaelgugino
Copy link
Contributor

michaelgugino commented May 7, 2018

Currently, if openshift_facts is invoked with
either the master, node, or common role, values
from master.portal_net may be mistakenly copied into
common.portal_net resulting in undesired behavior.

These facts do not need to be 'migrated' any longer
as the common facts are set directly.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571992

Currently, if openshift_facts is invoked with
either the master, node, or common role, values
from master.portal_net may be mistakenly copied into
common.portal_net resulting in undesired behavior.

These facts do not need to be 'migrated' any longer
as the common facts are set directly.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571992
@openshift-ci-robot openshift-ci-robot requested review from mtnbikenc and vrutkovs May 7, 2018
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented May 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson

This comment has been minimized.

Copy link
Member

sdodson commented May 8, 2018

/retest
/lgtm

@sdodson

This comment has been minimized.

Copy link
Member

sdodson commented May 8, 2018

bot, retest this please

@openshift-merge-robot openshift-merge-robot merged commit 2a017cc into openshift:master May 8, 2018
9 checks passed
9 checks passed
ci/openshift-jenkins/gcp Jenkins job succeeded.
Details
ci/openshift-jenkins/gcp-upgrade Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fedora/27/atomic All tests passed.
Details
fedora/27/atomic/master-ha All tests passed.
Details
fedora/27/atomic/update All tests passed.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.