Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo in openshift_metrics_cassandra_pvc_storage_class_name variable #8624

Merged
merged 1 commit into from Jun 6, 2018

Conversation

@faust64
Copy link
Contributor

commented Jun 4, 2018

mis-named variable

typo
mis-named variable
@papr-bot

This comment has been minimized.

Copy link

commented Jun 4, 2018

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
@DanyC97

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2018

can you please amend the PR title and the commit message to be more meaningful ?

@michaelgugino

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2018

/ok-to-test

@ewolinetz

@ewolinetz ewolinetz changed the title typo Fixing typo in openshift_metrics_cassandra_pvc_storage_class_name variable Jun 6, 2018
@ewolinetz

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

cc @jsanda
/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Jun 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, faust64

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ewolinetz

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

/test tox

@openshift-merge-robot openshift-merge-robot merged commit 3b0d7b2 into openshift:master Jun 6, 2018
7 checks passed
7 checks passed
ci/openshift-jenkins/gcp Jenkins job succeeded.
Details
ci/openshift-jenkins/gcp-upgrade Jenkins job succeeded.
Details
ci/openshift-jenkins/install Jenkins job succeeded.
Details
ci/openshift-jenkins/logging Skipped
ci/openshift-jenkins/tox Jenkins job succeeded.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details
@ewolinetz

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

thanks @faust64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.