Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BZ 1590449] Add support for standalone hawkular-metrics schema installer #8961

Closed
wants to merge 1 commit into from
Closed

[BZ 1590449] Add support for standalone hawkular-metrics schema installer #8961

wants to merge 1 commit into from

Conversation

rubenvp8510
Copy link
Contributor

@rubenvp8510 rubenvp8510 commented Jun 25, 2018 •
edited

This is a backport of #7683 to 3.9.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

vrutkovs
vrutkovs reviewed Jun 26, 2018
View reviewed changes
roles/openshift_metrics/tasks/install_hawkular_schema_job.yaml Outdated
@@ -0,0 +1,21 @@
---
- name: list installed jobs
command: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use oc_obj instead

@vrutkovs
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2018
@vrutkovs
Copy link
Member

bot, test pull request

@jsanda
Copy link
Contributor

jsanda commented Jun 26, 2018

We need these changes merged into the 3.7 and 3.6 branches as well. Here are the corresponding tickets for reference:

@vrutkovs
Copy link
Member

vrutkovs commented Jun 27, 2018 •
edited

Do not merge yet.

Is this WIP or we're holding for some other reason?

@jsanda
Copy link
Contributor

jsanda commented Jun 28, 2018

@vrutkovs The necessary changes for hawkular-metrics have not yet made it into distgit, hence the do not merge msg. As soon as the changes get committed, we will update this PR. Thanks in advance for the review!

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rubenvp8510
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rubenvp8510
Copy link
Contributor Author

rubenvp8510 commented Jul 19, 2018 •
edited

@vrutkovs This PR is ready for another review, not sure why tests are failing.

@rubenvp8510
Copy link
Contributor Author

/retest

@vrutkovs
Copy link
Member

Looks like GCP is flaking
/test gcp

@openshift-ci-robot
Copy link

@rubenvp8510: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 71d55c3 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs
vrutkovs requested changes Jul 20, 2018
View reviewed changes
roles/openshift_metrics/templates/hawkular_metrics_schema_job.j2
#name: hawkular-metrics
containers:
- name: hawkular-metrics-schema
image: {{openshift_metrics_image_prefix}}metrics-schema-installer:{{openshift_metrics_image_version}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist, it resolves to docker.io/openshift/origin-metrics-schema-installer:v3.9 for Origin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenvp8510 I think this is blocking the merge of this PR, have you had a chance to check on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the scripts for push the metrics-schema image to dockerhub are already updated on master, but the image is not there, still investigating what I need to do or who I need to talk with in order to push the images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are publishing images for master, is that not appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@vrutkovs vrutkovs vrutkovs requested changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rubenvp8510 @papr-bot @vrutkovs @jsanda @openshift-ci-robot @sdodson @stevekuznetsov