New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1590920. Bump fluent default memory to 756M #9165
Conversation
|
@mffiedler Is your opinion we should backport this to 3.10? |
|
@jcantrill IMO yes a backport to 3.10 would be good. 3.10 steady state fluentd rss is up to 50% higher than 3.9, in part depending on how much buffering and retries are taking place. Functionally, this seems to be the tradeoff for the greatly improved reduction in duplicates and message loss. The higher memory limit should help reduce oom kills and restarts for the workload I was running (500 1K messages/second/fluentd). Other workloads might still require tuning the value further. |
|
/test logging |
|
bot, retest this please |
|
/test logging |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test logging |
|
/cherrypick release-3.10 |
|
@jcantrill: new pull request created: #9191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1590920 by bumping the default OOTB memory for fluent to support prometheus metrics and buffer retry q's