Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1590920. Bump fluent default memory to 756M #9165

Merged
merged 1 commit into from Jul 13, 2018

Conversation

jcantrill
Copy link
Contributor

This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1590920 by bumping the default OOTB memory for fluent to support prometheus metrics and buffer retry q's

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2018
@jcantrill
Copy link
Contributor Author

@mffiedler Is your opinion we should backport this to 3.10?

@jcantrill jcantrill requested review from ewolinetz and removed request for ewolinetz and richm July 11, 2018 19:18
@mffiedler
Copy link

@jcantrill IMO yes a backport to 3.10 would be good. 3.10 steady state fluentd rss is up to 50% higher than 3.9, in part depending on how much buffering and retries are taking place. Functionally, this seems to be the tradeoff for the greatly improved reduction in duplicates and message loss. The higher memory limit should help reduce oom kills and restarts for the workload I was running (500 1K messages/second/fluentd).

Other workloads might still require tuning the value further.

@jcantrill
Copy link
Contributor Author

/test logging

@ewolinetz
Copy link
Contributor

bot, retest this please

@ewolinetz
Copy link
Contributor

/test logging

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richm
Copy link
Contributor

richm commented Jul 13, 2018

/test logging

@openshift-merge-robot openshift-merge-robot merged commit 3f3c674 into openshift:master Jul 13, 2018
@jcantrill jcantrill deleted the 1590920 branch July 13, 2018 12:22
@jcantrill
Copy link
Contributor Author

/cherrypick release-3.10

@openshift-cherrypick-robot

@jcantrill: new pull request created: #9191

In response to this:

/cherrypick release-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_3.10 approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants