Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding min-port to dnsmasq configuration. #9505

Merged
merged 1 commit into from Aug 10, 2018

Conversation

rjhowe
Copy link
Contributor

@rjhowe rjhowe commented Aug 9, 2018

By default dnsmasq uses lower port (for source port) for it's communications.
This sometimes create problem when the forward server is bind or
firewalls dropping queries coming from these reserved ports.

Upstream dnsmasq defaults setting min-port to 1024, for older versions
of dnsmasq setting min-port to 1024 is needed, to avoid random drops.

https://bugzilla.redhat.com/show_bug.cgi?id=1600551
https://bugzilla.redhat.com/show_bug.cgi?id=1614331

By default dnsmasq uses lower port (for source port) for it's communications.
This sometimes create problem when the forward server is bind or
firewalls dropping queries coming from these reserved ports.

Upstream dnsmasq defaults setting min-port to 1024, for older versions
of dnsmasq setting min-port to 1024 is needed, to avoid random drops.

https://bugzilla.redhat.com/show_bug.cgi?id=1600551
https://bugzilla.redhat.com/show_bug.cgi?id=1614331
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2018
@ironcladlou
Copy link
Contributor

Awesome! Regarding upgrades:

  • Will that conf file get overwritten automatically?
  • Wil dnsmasq be restarted automatically?

/cc @sdodson @imcsk8

@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

Will that conf file get overwritten automatically?

Yes, we run through roles/openshift_node/tasks/dnsmasq.yml during upgrades via https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_node/tasks/upgrade.yml#L54

Wil dnsmasq be restarted automatically?

Yes, if we apply changes to the configuration file, if there are no changes applied it won't restart the service.

@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

This
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2018
@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjhowe, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2018
@sdodson
Copy link
Member

sdodson commented Aug 9, 2018

BTW, in older releases we should verify that what I've said about this being applied is true, we simplified all of this in 3.10 or 3.9 so older may require different changes.

@imcsk8
Copy link
Contributor

imcsk8 commented Aug 9, 2018

LGTM

@ironcladlou
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@rjhowe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 17fc91c link /test gcp
ci/prow/gcp-crio 17fc91c link /test gcp-crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Aug 10, 2018

This is failing due to the same problem we're debugging here openshift/origin#20604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants