New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding min-port to dnsmasq configuration. #9505
Conversation
By default dnsmasq uses lower port (for source port) for it's communications. This sometimes create problem when the forward server is bind or firewalls dropping queries coming from these reserved ports. Upstream dnsmasq defaults setting min-port to 1024, for older versions of dnsmasq setting min-port to 1024 is needed, to avoid random drops. https://bugzilla.redhat.com/show_bug.cgi?id=1600551 https://bugzilla.redhat.com/show_bug.cgi?id=1614331
Yes, we run through roles/openshift_node/tasks/dnsmasq.yml during upgrades via https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_node/tasks/upgrade.yml#L54
Yes, if we apply changes to the configuration file, if there are no changes applied it won't restart the service. |
|
This |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjhowe, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
BTW, in older releases we should verify that what I've said about this being applied is true, we simplified all of this in 3.10 or 3.9 so older may require different changes. |
|
LGTM |
|
/retest |
|
@rjhowe: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is failing due to the same problem we're debugging here openshift/origin#20604 |
By default dnsmasq uses lower port (for source port) for it's communications.
This sometimes create problem when the forward server is bind or
firewalls dropping queries coming from these reserved ports.
Upstream dnsmasq defaults setting min-port to 1024, for older versions
of dnsmasq setting min-port to 1024 is needed, to avoid random drops.
https://bugzilla.redhat.com/show_bug.cgi?id=1600551
https://bugzilla.redhat.com/show_bug.cgi?id=1614331