Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Adding min-port to dnsmasq configuration #9542

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Aug 10, 2018

By default, older versions of dnsmasq can use lower-numbered source ports for outbound DNS queries. This sometimes creates problems; for example, firewall rules may drop queries coming from these reserved ports.

To avoid these problems, we can set the minimum port number for outbound queries using dnsmasq's min-port setting. dnsmasq 2.79 defaults min-port to 1024; for older versions of dnsmasq, we must set min-port to 1024.

This commit fixes bug 1614984.

https://bugzilla.redhat.com/show_bug.cgi?id=1614984


Cherry-picked from #9505

By default, older versions of dnsmasq can use lower-numbered source ports
for outbound DNS queries.  This sometimes creates problems; for example,
firewall rules may drop queries coming from these reserved ports.

To avoid these problems, we can set the minimum port number for outbound
queries using dnsmasq's min-port setting.  dnsmasq 2.79 defaults min-port
to 1024; for older versions of dnsmasq, we must set min-port to 1024.

This commit fixes bug 1614984.

https://bugzilla.redhat.com/show_bug.cgi?id=1614984
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2018
@Miciah Miciah changed the title Adding min-port to dnsmasq configuration [3.10] Adding min-port to dnsmasq configuration Aug 10, 2018
@vrutkovs
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2018
@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

/test gcp

@Miciah
Copy link
Contributor Author

Miciah commented Aug 13, 2018

This may mean the job has not yet uploaded any artifacts, or that it failed to upload.

/retest

@vrutkovs
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit bd2bcff into openshift:release-3.10 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants