New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install #9561
[release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install #9561
Conversation
|
The gcp test is still failing because the 3.9 origin image is still out of date. |
| #openshift_use_crio=False | ||
| # You can install cri-o as an rpm by setting the following variable: | ||
| #openshift_crio_use_rpm=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add openshift_crio_use_rpm to __warn_deprecated_vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should do that. Make a note to just remove in 3.12, no need to fail if that's defined as it won't really affect anything.
7b9e65b
to
bc97727
Compare
|
@vrutkovs @michaelgugino Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/test gcp |
3 similar comments
|
/test gcp |
|
/test gcp |
|
/test gcp |
|
/test gcp |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michaelgugino, mtnbikenc If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mtnbikenc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
GCP test won't pass, merged manually |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614916