Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install #9561

Merged
merged 1 commit into from Aug 16, 2018

Conversation

mtnbikenc
Copy link
Member

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2018
@mtnbikenc
Copy link
Member Author

The gcp test is still failing because the 3.9 origin image is still out of date.

#openshift_use_crio=False
# You can install cri-o as an rpm by setting the following variable:
#openshift_crio_use_rpm=False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add openshift_crio_use_rpm to __warn_deprecated_vars?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should do that. Make a note to just remove in 3.12, no need to fail if that's defined as it won't really affect anything.

@mtnbikenc
Copy link
Member Author

@vrutkovs @michaelgugino Updated.

Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@vrutkovs
Copy link
Member

/test gcp

3 similar comments
@vrutkovs
Copy link
Member

/test gcp

@mtnbikenc
Copy link
Member Author

/test gcp

@vrutkovs
Copy link
Member

/test gcp

@mtnbikenc mtnbikenc changed the title [WIP] [Bug 1614916] [release-3.9] Default 3.9 to use RPM based CRI-O install [WIP] [release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install Aug 16, 2018
@mtnbikenc
Copy link
Member Author

/test gcp
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelgugino, mtnbikenc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@mtnbikenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp bc97727 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtnbikenc mtnbikenc changed the title [WIP] [release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install [release-3.9] [Bug 1614916] Default 3.9 to use RPM based CRI-O install Aug 16, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2018
@vrutkovs vrutkovs merged commit 1f248b1 into openshift:release-3.9 Aug 16, 2018
@vrutkovs
Copy link
Member

GCP test won't pass, merged manually

@mtnbikenc mtnbikenc deleted the release-3.9-fix-1614916 branch August 16, 2018 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants