New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.10] Refactor csr approvals: oc_csr_approve #9751
[3.10] Refactor csr approvals: oc_csr_approve #9751
Conversation
Currently, csr approval process for nodes is quite fragile. This commit creates a new custom module oc_csr_approve which facilitates handling the multiple steps involved for approving pending node certificates. The module attempts to approve all 'client' csrs for any nodes provided via node_list, missing csrs are ignored as long as the missing node is in a 'Ready' status as reported by oc get nodes. Next, the module approves csrs for 'server' certificates. Similar to the client process, missing node csrs are acceptable as long as the node's api endpoint is reachable without error, indicating a server certificate is deployed. In cases of long delay between issuing a csr and csr approval, there may be several outstanding 'server' csrs. This module will approve any outstanding csrs. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571515 (cherry picked from commit fef0430)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@michaelgugino: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
gcp test previously passed. Flake. |
Backports: #9711
Currently, csr approval process for nodes is quite
fragile.
This commit creates a new custom module oc_csr_approve
which facilitates handling the multiple steps involved
for approving pending node certificates.
The module attempts to approve all 'client' csrs
for any nodes provided via node_list, missing csrs
are ignored as long as the missing node is in a
'Ready' status as reported by oc get nodes.
Next, the module approves csrs for 'server' certificates.
Similar to the client process, missing node csrs
are acceptable as long as the node's api endpoint
is reachable without error, indicating a server
certificate is deployed.
In cases of long delay between issuing a csr and
csr approval, there may be several outstanding
'server' csrs. This module will approve any
outstanding csrs.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1571515
(cherry picked from commit fef0430)