Fix aws elb dictionary fact for dns

[michaelgugino]

This commit ensures we use proper element of registered
output.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1569631

[michaelgugino]

Playbook to test this fix if you're so inclined:

---
- hosts: localhost
  connection: local
  roles:
  - lib_utils
  vars:
    openshift_aws_elb_names:
    - mgugino-dev-test1
    - mgugino-dev-test2

  tasks:
  - import_role:
      name: openshift_aws
      tasks_from: build_elb_dict.yml
  - debug:
      var: l_openshift_aws_elb_facts['mgugino-dev-test1']

Replace my elb names with yours.

[mazzystr]

/lgtm

External:

PLAY [provision dns] *******************************************************************************************************************************

TASK [Gathering Facts] *****************************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : query vpc] *******************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : debug vcpout] ****************************************************************************************************************
skipping: [localhost]

TASK [openshift_aws : fetch the subnet ids] ********************************************************************************************************
ok: [localhost] => (item=us-east-1c)

TASK [openshift_aws : debug subnetout] *************************************************************************************************************
skipping: [localhost]

TASK [openshift_aws : querying elb] ****************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : set elb fact dictionary] *****************************************************************************************************
ok: [localhost]

TASK [openshift_aws : creating route53 zone(s)] ****************************************************************************************************
ok: [localhost] => (item=)

TASK [openshift_aws : creating record] *************************************************************************************************************
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'logs'})
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'internal-ccallegar-master-internal-1281729031.us-east-1.elb.amazonaws.com'}, 'key': u'internal.api'})
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'metrics'})
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-master-external-256718537.us-east-1.elb.amazonaws.com'}, 'key': u'api'})
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'registry'})
changed: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'*.apps'})

TASK [include_role : {{ openshift_aws_custom_dns_provider_role }}] *********************************************************************************
skipping: [localhost]

External + Internal:

PLAY [provision dns] *******************************************************************************************************************************

TASK [Gathering Facts] *****************************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : query vpc] *******************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : debug vcpout] ****************************************************************************************************************
skipping: [localhost]

TASK [openshift_aws : fetch the subnet ids] ********************************************************************************************************
ok: [localhost] => (item=us-east-1c)

TASK [openshift_aws : debug subnetout] *************************************************************************************************************
skipping: [localhost]

TASK [openshift_aws : querying elb] ****************************************************************************************************************
ok: [localhost]

TASK [openshift_aws : set elb fact dictionary] *****************************************************************************************************
ok: [localhost]

TASK [openshift_aws : creating route53 zone(s)] ****************************************************************************************************
ok: [localhost] => (item=)
changed: [localhost] => (item=vpc-2d6ebb57)

TASK [openshift_aws : creating record] *************************************************************************************************************
ok: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'logs'})
changed: [localhost] => (item={'value': {u'private_zone': True, u'type': u'CNAME', u'value': u'internal-ccallegar-master-internal-1281729031.us-east-1.elb.amazonaws.com'}, 'key': u'internal.api'})
ok: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'metrics'})
ok: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-master-external-256718537.us-east-1.elb.amazonaws.com'}, 'key': u'api'})
ok: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'registry'})
ok: [localhost] => (item={'value': {u'private_zone': False, u'type': u'CNAME', u'value': u'ccallegar-infra-836535944.us-east-1.elb.amazonaws.com'}, 'key': u'*.apps'})

TASK [include_role : {{ openshift_aws_custom_dns_provider_role }}] *********************************************************************************
skipping: [localhost]

[sdodson]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr, michaelgugino, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• roles/openshift_aws/OWNERS [michaelgugino,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment