Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] Approve node CSRs during restart #9817

Merged
merged 1 commit into from Aug 29, 2018

Conversation

mtnbikenc
Copy link
Member

  • Remove conditional associated with skipping checks during incremental
    upgrades
  • Use new oc_csr_approve

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1618659

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
* Remove conditional associated with skipping checks during incremental
upgrades
* Use new oc_csr_approve

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1618659
@sdodson
Copy link
Member

sdodson commented Aug 29, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adammhaile
Copy link
Contributor

/me watching... need to rebuild this ASAP

@mtnbikenc
Copy link
Member Author

/test gcp

@mtnbikenc
Copy link
Member Author

operator Instantiate the template e2e-gcp into the operator namespace and wait for any pods to complete
/test gcp

@sdodson
Copy link
Member

sdodson commented Aug 29, 2018

These fixes are time critical and upgrades are not exercised by these tests.

@sdodson sdodson merged commit c8adf66 into openshift:release-3.10 Aug 29, 2018
@openshift-ci-robot
Copy link

@mtnbikenc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/install eb72b04 link /test install
ci/prow/gcp eb72b04 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtnbikenc mtnbikenc deleted the release-3.10-fix-1618659 branch August 29, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants