New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove configmap check during upgrades #9951
Conversation
This check is no longer necessary once a cluster is running 3.10. As new default node groups are added, the check would fail on upgrades unnecessarily.
|
It looks like this was the task that caused the failure for https://bugzilla.redhat.com/show_bug.cgi?id=1626223 +1 to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino, mtnbikenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mtnbikenc does this need to go in "release-3.11" branch rather than master? |
|
Is this supposed to resolve "Configmap for node-config-master-crio must be present" when upgrading from 3.9 > 3.10? Still running into this error and this installation doesn't even use crio. |
|
/cherrypick release-3.11 |
|
@michaelgugino: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.11 and openshift-cherrypick-robot:cherry-pick-9951-to-release-3.11"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@feld-ims no, this is not to address that. You'll need to consult the release notes/upgrade documentation for 3.9 to 3.10 upgrades, lots of changes. |
This check is no longer necessary once a cluster is running 3.10.
As new default node groups are added, the check would fail on upgrades
unnecessarily.