Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configmap check during upgrades #9951

Merged
merged 1 commit into from Sep 6, 2018

Conversation

mtnbikenc
Copy link
Member

This check is no longer necessary once a cluster is running 3.10.
As new default node groups are added, the check would fail on upgrades
unnecessarily.

This check is no longer necessary once a cluster is running 3.10.
As new default node groups are added, the check would fail on upgrades
unnecessarily.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2018
@mbruzek
Copy link
Contributor

mbruzek commented Sep 6, 2018

It looks like this was the task that caused the failure for https://bugzilla.redhat.com/show_bug.cgi?id=1626223

+1 to this change.

Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino, mtnbikenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelgugino,mtnbikenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5c5ae65 into openshift:master Sep 6, 2018
@mtnbikenc mtnbikenc deleted the fix-1626223 branch September 7, 2018 00:44
@mbruzek
Copy link
Contributor

mbruzek commented Sep 7, 2018

@mtnbikenc does this need to go in "release-3.11" branch rather than master?

@felsys
Copy link

felsys commented Oct 9, 2018

Is this supposed to resolve "Configmap for node-config-master-crio must be present" when upgrading from 3.9 > 3.10? Still running into this error and this installation doesn't even use crio.

@michaelgugino
Copy link
Contributor

/cherrypick release-3.11

@openshift-cherrypick-robot

@michaelgugino: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-3.11 and openshift-cherrypick-robot:cherry-pick-9951-to-release-3.11"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link
Contributor

@feld-ims no, this is not to address that. You'll need to consult the release notes/upgrade documentation for 3.9 to 3.10 upgrades, lots of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants