Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1844495: TagEvent and TagEventCondition conversions #119

Merged
merged 1 commit into from Aug 3, 2020
Merged

Bug 1844495: TagEvent and TagEventCondition conversions #119

merged 1 commit into from Aug 3, 2020

Conversation

ricardomaraschini
Copy link
Contributor

Implemented manual conversions for TagEvent and TagEventCondition
slices.

Related to PR #95

@ricardomaraschini
Copy link
Contributor Author

/assign @dmage

@ricardomaraschini ricardomaraschini changed the title TagEvent and TagEventCondition conversions Bug 1844495: TagEvent and TagEventCondition conversions Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1844495, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1844495: TagEvent and TagEventCondition conversions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Implemented manual conversions for TagEvent and TagEventCondition
slices.
@dmage
Copy link
Member

dmage commented Jun 18, 2020

/lgtm
/assign @deads2k

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@ricardomaraschini
Copy link
Contributor Author

/retest

@mfojtik
Copy link
Member

mfojtik commented Aug 3, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, mfojtik, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0d9fc43 into openshift:master Aug 3, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1844495: TagEvent and TagEventCondition conversions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants