Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of %w formatting directive from t.Errorf call. #293

Merged
merged 1 commit into from Sep 27, 2022

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Jul 6, 2022

The printf analyzer flags this as an error and fails to build in later
Go 1.18 releases due to this change:

https://go-review.googlesource.com/c/tools/+/340409/5/go/analysis/passes/printf/printf.go.

The printf analyzer flags this as an error and fails to build in later
Go 1.18 releases due to this change:

https://go-review.googlesource.com/c/tools/+/340409/5/go/analysis/passes/printf/printf.go.
@openshift-ci openshift-ci bot requested review from pweil- and stlaz July 6, 2022 17:00
@benluddy
Copy link
Contributor Author

benluddy commented Jul 6, 2022

$ make test-unit
...
# github.com/openshift/openshift-apiserver/pkg/security/apiserver/registry/podsecuritypolicyselfsubjectreview
pkg/security/apiserver/registry/podsecuritypolicyselfsubjectreview/rest_test.go:88:4: (*testing.common).Errorf does not support error-wrapping directive %w
...
FAIL	github.com/openshift/openshift-apiserver/pkg/security/apiserver/registry/podsecuritypolicyselfsubjectreview [build failed]
FAIL

@benluddy
Copy link
Contributor Author

/retest-required

@dgrisonnet
Copy link
Member

/lgtm
/assign @tkashem

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@deads2k
Copy link
Contributor

deads2k commented Sep 23, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k, dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ee7ddb and 2 for PR HEAD 0877044 in total

@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest-required

@benluddy
Copy link
Contributor Author

/test e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

@benluddy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ae6616f into openshift:master Sep 27, 2022
@dgrisonnet
Copy link
Member

Cherry-pick to 4.11 for #274.

/cherry-pick release-4.11

@openshift-cherrypick-robot

@dgrisonnet: new pull request created: #330

In response to this:

Cherry-pick to 4.11 for #274.

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants