New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability of reading configmaps to shared-resource-viewer role #42
Add capability of reading configmaps to shared-resource-viewer role #42
Conversation
This role enables authenticated users to be able to read resources from the "openshift" namespace. For the "motd" feature [1] to work, the role needs to enable users to read configmaps as well. This PR enables that. [1] openshift/oc#67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test e2e-aws |
The PR openshift/openshift-apiserver#42 adds this rule to the defaults; so, we need to expect it as part of the tests.
/test e2e-aws |
3 similar comments
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This role enables authenticated users to be able to read resources from
the "openshift" namespace. For the "motd" feature [1] to work, the role
needs to enable users to read configmaps as well. This PR enables that.
[1] openshift/oc#67