bump to kubernetes-1.17.0-beta.2 #44

mfojtik · 2019-11-15T12:46:48Z

This moves openshift-apiserver to kubernetes 1.17.0-beta.2 which include dynamic certificate reloading and other fixes in aggregated apiservers.

The apiserver-library-go was also bumped to 1.17.0-beta.2: https://github.com/openshift/apiserver-library-go/tree/openshift-apiserver-4.3-kubernetes-1.17.0-beta.2 (surprisingly tolerating library-go still being on 1.16.2).

mfojtik · 2019-11-15T12:46:58Z

@deads2k as promised

mfojtik · 2019-11-15T15:28:47Z

/hold

we need kube tag to move forward

mfojtik · 2019-11-19T13:03:10Z

@sttts the openapi generation fail with:

E1119 14:01:39.582048   59789 openapi.go:304] Error when generating: managementState, ManagementState github.com/openshift/api/operator/v1.ManagementState
2019/11/19 14:01:39 OpenAPI code generation error: Failed executing generator: some packages had errors:
Tags in comment and struct should match for member (ManagementState) of (github.com/openshift/api/samples/v1.ConfigStatus)

/cc @damemi

tnozicka · 2019-11-19T13:34:21Z

pkg/apps/apis/apps/log_options_test.go

@@ -15,6 +15,10 @@ func TestLogOptionsDrift(t *testing.T) {
 		// Verify name
 		name := popts.Field(i).Name
 		doptsField, found := dopts.FieldByName(name)
+		// TODO: Add this option to deployment config log options


followup with a BZ seems fine to me

followup with a BZ seems fine to me

Yeah, BZ for 4.4. it's not urgent.

pkg/cmd/openshift-apiserver/server.go

pkg/authorization/apiserver/registry/subjectaccessreview/rest.go

pkg/authorization/apis/authorization/v1/zz_generated.conversion.go

pkg/authorization/apiserver/registry/subjectaccessreview/rest.go

deads2k · 2019-11-19T14:54:37Z

fairly minor comments. The biggest one is the question of fuzzing tests.

mfojtik · 2019-11-19T16:28:24Z

Follow up list:

Make a BZ for new log options field
Make a BZ doe @openshift/openshift-team-developer-experience for disabled unit test

mfojtik · 2019-11-20T07:52:49Z

@deads2k whoah e2e passed :)

mfojtik · 2019-11-20T11:39:54Z

/retest

…test

mfojtik · 2019-11-20T12:27:24Z

/hold cancel

mfojtik · 2019-11-20T12:40:37Z

@deads2k @sttts @adambkaplan @bparees this is ready for review

deads2k · 2019-11-20T14:14:22Z

pkg/apps/apis/apps/v1/zz_generated.conversion.go

@@ -174,16 +174,6 @@ func RegisterConversions(s *runtime.Scheme) error {
 	}); err != nil {
 		return err
 	}
-	if err := s.AddGeneratedConversionFunc((*v1.DeploymentTriggerImageChangeParams)(nil), (*apps.DeploymentTriggerImageChangeParams)(nil), func(a, b interface{}, scope conversion.Scope) error {


reminder for future me. These were actually registered twice before. The fuzz tests appear to be working, so we're good.

deads2k · 2019-11-20T14:15:09Z

/lgtm

openshift-ci-robot · 2019-11-20T14:15:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This reverts commit 2e7b3f6, reversing changes made to 29b6805.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2019

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2019

openshift-ci-robot requested review from deads2k and sttts November 15, 2019 12:47

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019

mfojtik force-pushed the bump-kube-1.17 branch from 189ada6 to 0e6a1c6 Compare November 19, 2019 12:20

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2019

mfojtik changed the title ~~WIP: bump to kubernetes-1.17.0-beta.1 + dynamic reload patches~~ WIP: bump to kubernetes-1.17.0-beta.2 Nov 19, 2019

mfojtik force-pushed the bump-kube-1.17 branch from 0e6a1c6 to 077fe40 Compare November 19, 2019 12:24

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2019

mfojtik force-pushed the bump-kube-1.17 branch from 9ef1a8d to 2b98b18 Compare November 19, 2019 12:51

openshift-ci-robot requested a review from damemi November 19, 2019 13:03

tnozicka reviewed Nov 19, 2019

View reviewed changes

deads2k reviewed Nov 19, 2019

View reviewed changes

pkg/cmd/openshift-apiserver/server.go Outdated Show resolved Hide resolved

deads2k reviewed Nov 19, 2019

View reviewed changes

pkg/authorization/apiserver/registry/subjectaccessreview/rest.go Outdated Show resolved Hide resolved

deads2k reviewed Nov 19, 2019

View reviewed changes

pkg/authorization/apis/authorization/v1/zz_generated.conversion.go Show resolved Hide resolved

deads2k reviewed Nov 19, 2019

View reviewed changes

pkg/authorization/apiserver/registry/subjectaccessreview/rest.go Outdated Show resolved Hide resolved

mfojtik mentioned this pull request Nov 19, 2019

samples: add pathMergeKey and pathStrategy tags openshift/api#520

Merged

mfojtik force-pushed the bump-kube-1.17 branch 2 times, most recently from f2e8073 to 5410890 Compare November 19, 2019 16:22

mfojtik added 2 commits November 20, 2019 12:42

go.mod: bump to kube-1.17.0-beta.1+dynamic reload

3059552

bump(*): update vendor for kube 1.17.0-beta.1

a66348a

mfojtik added 6 commits November 20, 2019 12:42

interesting: wire context to podsecuritypolicy

7676e37

interesting(tnozicka): sync DeploymentLogOptions with PodLogOptions

5baacf2

interesting(adam): sync BuildLogOptions with PodLogOptions

0da186c

boring: add context to authorization unit tests

cc1ac07

interesting(adam): fix imagestream unit tests

b69b4ad

boring: wire context to pod security unit tests

50e3c21

mfojtik force-pushed the bump-kube-1.17 branch 2 times, most recently from 2868498 to d225f3d Compare November 20, 2019 11:51

mfojtik added 2 commits November 20, 2019 13:22

interesting: update generated conversions

d9fea7d

interesting: update generated openapi

2aae23b

mfojtik force-pushed the bump-kube-1.17 branch from d225f3d to bd917af Compare November 20, 2019 12:22

mfojtik and others added 5 commits November 20, 2019 13:25

boring: set the default namespace for buildconfig in test

28ecf7a

boring: use default namespace in podsecuritypolicy sar unit test

01ce943

boring: fix context in SAR apiserver

bd44228

interesting(devexp): Disabled TestValidateImageStreamWithWhitelister …

564ce54

…test

use more realistic fake images

6863753

mfojtik force-pushed the bump-kube-1.17 branch from bd917af to 6863753 Compare November 20, 2019 12:25

mfojtik changed the title ~~WIP: bump to kubernetes-1.17.0-beta.2~~ bump to kubernetes-1.17.0-beta.2 Nov 20, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2019

deads2k reviewed Nov 20, 2019

View reviewed changes

openshift-ci-robot assigned deads2k Nov 20, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019

openshift-merge-robot merged commit 2e7b3f6 into openshift:master Nov 20, 2019

deads2k added a commit to deads2k/openshift-apiserver that referenced this pull request Dec 13, 2019

Revert "Merge pull request openshift#44 from mfojtik/bump-kube-1.17"

edaa056

This reverts commit 2e7b3f6, reversing changes made to 29b6805.

deads2k added a commit to deads2k/openshift-apiserver that referenced this pull request Dec 13, 2019

Revert "Merge pull request openshift#44 from mfojtik/bump-kube-1.17"

7b7cc97

This reverts commit 2e7b3f6, reversing changes made to 29b6805.

bump to kubernetes-1.17.0-beta.2 #44

bump to kubernetes-1.17.0-beta.2 #44

mfojtik commented Nov 15, 2019 •

edited

mfojtik commented Nov 15, 2019

mfojtik commented Nov 15, 2019

mfojtik commented Nov 19, 2019

tnozicka Nov 19, 2019

deads2k Nov 19, 2019

deads2k commented Nov 19, 2019

mfojtik commented Nov 19, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

deads2k Nov 20, 2019

deads2k commented Nov 20, 2019

openshift-ci-robot commented Nov 20, 2019

bump to kubernetes-1.17.0-beta.2 #44

bump to kubernetes-1.17.0-beta.2 #44

Conversation

mfojtik commented Nov 15, 2019 • edited

mfojtik commented Nov 15, 2019

mfojtik commented Nov 15, 2019

mfojtik commented Nov 19, 2019

tnozicka Nov 19, 2019

Choose a reason for hiding this comment

deads2k Nov 19, 2019

Choose a reason for hiding this comment

deads2k commented Nov 19, 2019

mfojtik commented Nov 19, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

mfojtik commented Nov 20, 2019

deads2k Nov 20, 2019

Choose a reason for hiding this comment

deads2k commented Nov 20, 2019

openshift-ci-robot commented Nov 20, 2019

mfojtik commented Nov 15, 2019 •

edited