Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release 4.4] Bug 1811202: /readyz should start returning failure on shutdown initiation #81

Merged
merged 2 commits into from Mar 13, 2020
Merged

[release 4.4] Bug 1811202: /readyz should start returning failure on shutdown initiation #81

merged 2 commits into from Mar 13, 2020

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Mar 9, 2020 •
edited

re-vendor openshift/kubernetes-apiserver, this will bring in the following change:

  • UPSTREAM 88911: /readyz should start returning failure on shutdown initiation

@tkashem
ensure vendor folder is in sync
6d02ac7 
run `go mod vendor` and `go mod tidy` and save changes to go.sum
@tkashem
revendor openshift/kubernetes-apiserver
e48a254 
revendor the latest of openshift-apiserver-4.4-kubernetes-1.17.3
branch of openshift/kubernetes-apiserver.

This will bring in the following change:
- UPSTREAM 88911: /readyz should start returning failure on shutdown initiation
@openshift-ci-robot
Copy link

@tkashem: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

revendor openshift/kubernetes-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2020
@tkashem tkashem changed the title revendor openshift/kubernetes-apiserver Bug 1811801: revendor openshift/kubernetes-apiserver Mar 9, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811801, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
  • expected dependent Bugzilla bug 1811202 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1811801: revendor openshift/kubernetes-apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 9, 2020
@tkashem tkashem changed the title Bug 1811801: revendor openshift/kubernetes-apiserver Bug 1811801: /readyz should start returning failure on shutdown initiation Mar 9, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811801, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.4.z" instead
  • expected dependent Bugzilla bug 1811202 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1811801: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Mar 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811801, which is invalid:

  • expected dependent Bugzilla bug 1811202 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem tkashem changed the title Bug 1811801: /readyz should start returning failure on shutdown initiation Bug 1811202: /readyz should start returning failure on shutdown initiation Mar 9, 2020
@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811202, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected Bugzilla bug 1811202 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1811202: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tkashem
Copy link
Contributor Author

tkashem commented Mar 9, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@tkashem: This pull request references Bugzilla bug 1811202, which is invalid:

  • expected dependent Bugzilla bug 1811801 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Mar 10, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@sttts sttts changed the title Bug 1811202: /readyz should start returning failure on shutdown initiation [release 4.4] Bug 1811202: /readyz should start returning failure on shutdown initiation Mar 10, 2020
@nee1esh
Copy link

nee1esh commented Mar 11, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@nee1esh: This pull request references Bugzilla bug 1811202, which is invalid:

  • expected dependent Bugzilla bug 1811801 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 13, 2020
@nee1esh
Copy link

nee1esh commented Mar 13, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 13, 2020
@openshift-ci-robot
Copy link

@nee1esh: This pull request references Bugzilla bug 1811202, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1811801 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1811801 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 13, 2020
@sttts
Copy link
Contributor

sttts commented Mar 13, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 325d99c into openshift:release-4.4 Mar 13, 2020
@openshift-ci-robot
Copy link

@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1811202 has been moved to the MODIFIED state.

In response to this:

[release 4.4] Bug 1811202: /readyz should start returning failure on shutdown initiation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tkashem @openshift-ci-robot @sttts @nee1esh @openshift-bot @mfojtik @openshift-merge-robot