Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing FIPS #1773

Merged
merged 1 commit into from Jul 3, 2019
Merged

Removing FIPS #1773

merged 1 commit into from Jul 3, 2019

Conversation

kwoodson
Copy link
Contributor

@kwoodson kwoodson commented Jul 3, 2019 •
edited

Removing FIPS mode to fix CIFS mounts.

Fixes #1772

None

@openshift-ci-robot openshift-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2019
@kwoodson kwoodson requested review from mjudeikis and removed request for charlesakalugwu July 3, 2019 01:33
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2019
@kwoodson
Copy link
Contributor Author

kwoodson commented Jul 3, 2019 •
edited

@mjudeikis if this works I went ahead and removed the exit bug from the script.sh. Feel free to close #1764

@kwoodson
Copy link
Contributor Author

kwoodson commented Jul 3, 2019

Poor CI: fatal: unable to access 'https://github.com/openshift/openshift-azure.git/': Could not resolve host: github.com

@kwoodson
Copy link
Contributor Author

kwoodson commented Jul 3, 2019

/retest

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1773 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1773   +/-   ##
=======================================
  Coverage   42.66%   42.66%           
=======================================
  Files         221      221           
  Lines       14210    14210           
=======================================
  Hits         6062     6062           
  Misses       7793     7793           
  Partials      355      355

@mjudeikis
Copy link
Contributor

/retest

mjudeikis
mjudeikis reviewed Jul 3, 2019
View reviewed changes
pkg/vmimage/data/script.sh
sed -i -re 's/GRUB_CMDLINE_LINUX="(.*)"$/GRUB_CMDLINE_LINUX="\1 fips=1"/' /etc/default/grub
grub2-mkconfig -o /boot/grub2/grub.cfg
grub2-mkconfig -o /boot/efi/EFI/redhat/grub.cfg
# dracut -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be good or to remove them at all

@mjudeikis
Copy link
Contributor

/lgtm
lets fix this as we now stuck for 2 w ;/

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kwoodson
Copy link
Contributor Author

kwoodson commented Jul 3, 2019

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

ehashman
ehashman approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, kwoodson, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ehashman,kwoodson,mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehashman ehashman mentioned this pull request Jul 3, 2019
Closed
@kwoodson
Copy link
Contributor Author

kwoodson commented Jul 3, 2019

Please @openshift-ci-robot, merge this quick before something else fails.

@openshift-merge-robot openshift-merge-robot merged commit 7f48a40 into openshift:master Jul 3, 2019
@charlesakalugwu
Copy link
Contributor

Please @openshift-ci-robot, merge this quick before something else fails.

haha that was awesome! 👯‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis mjudeikis left review comments

@ehashman ehashman ehashman approved these changes

Assignees

@mjudeikis mjudeikis

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIPS enabled images break azure-file storage class
7 participants
@kwoodson @mjudeikis @openshift-bot @openshift-ci-robot @charlesakalugwu @ehashman @openshift-merge-robot