Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.12.5 #2177

Merged

Conversation

@troy0820
Copy link
Member

troy0820 commented Jan 10, 2020

NONE
  • Bump version of go to 1.12.5 on vmimage
@troy0820 troy0820 force-pushed the troy0820:bump/golang-version branch from 209398e to f36a732 Jan 10, 2020
@openshift-ci-robot openshift-ci-robot requested review from gburges and pnasrat Jan 10, 2020
@openshift-ci-robot openshift-ci-robot added size/M and removed size/XS labels Jan 10, 2020
@troy0820 troy0820 force-pushed the troy0820:bump/golang-version branch from f36a732 to 4772f34 Jan 10, 2020
@openshift-ci-robot openshift-ci-robot added size/XS and removed size/M labels Jan 10, 2020
@troy0820 troy0820 force-pushed the troy0820:bump/golang-version branch from 4772f34 to 4032f64 Jan 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #2177 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2177   +/-   ##
======================================
  Coverage    43.4%   43.4%           
======================================
  Files         319     319           
  Lines       25198   25198           
======================================
  Hits        10936   10936           
  Misses      13637   13637           
  Partials      625     625
@mjudeikis

This comment has been minimized.

Copy link
Contributor

mjudeikis commented Jan 11, 2020

@troy0820 missing make generate

@troy0820 troy0820 force-pushed the troy0820:bump/golang-version branch from 4032f64 to ea81292 Jan 11, 2020
@openshift-ci-robot openshift-ci-robot added size/S and removed size/XS labels Jan 11, 2020
@mjudeikis

This comment has been minimized.

Copy link
Contributor

mjudeikis commented Jan 11, 2020

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Jan 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Jan 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Jan 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ef64521 into openshift:master Jan 12, 2020
10 checks passed
10 checks passed
ci/prow/images Job succeeded.
Details
e2e-create-20190430 Job succeeded.
Details
e2e-create-20191027-private Job succeeded.
Details
e2e-create-20191027-public Job succeeded.
Details
tide In merge pool.
Details
unit Job succeeded.
Details
upgrade-v10.1.1 Job succeeded.
Details
upgrade-v12.2 Job succeeded.
Details
upgrade-v7.1 Job succeeded.
Details
verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.