Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep v20 development #2318

Merged
merged 6 commits into from Jul 13, 2020
Merged

Conversation

ehashman
Copy link
Contributor

@ehashman ehashman commented Jul 8, 2020

NONE
  • Update pluginconfig
  • Remove old v14/v18 assets
  • Add v20 directories and wire them up
  • Update hash tests
  • Check in changes from latest goyacc update

@openshift-ci-robot openshift-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 8, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2318 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   41.36%   41.36%           
=======================================
  Files         305      305           
  Lines       23962    23962           
=======================================
  Hits         9912     9912           
  Misses      13470    13470           
  Partials      580      580           

Copy link
Contributor

@nilsanderselde nilsanderselde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

except for go generate produced changes that were not already present

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@nilsanderselde
Copy link
Contributor

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@nilsanderselde
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ehashman
Copy link
Contributor Author

ehashman commented Jul 9, 2020

/test e2e-create-20191027-private

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@ehashman
Copy link
Contributor Author

/test upgrade-v16.1-private

@openshift-ci-robot
Copy link

@ehashman: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test codecov
  • /test e2e-applysecurityupdates
  • /test conformance
  • /test e2e-carotation
  • /test e2e-changeloglevel
  • /test e2e-create-20190430
  • /test e2e-create-20190930
  • /test e2e-create-20191027-private
  • /test e2e-create-20191027-public
  • /test e2e-etcdbackuprecovery
  • /test e2e-forceupdate
  • /test e2e-keyrotation
  • /test e2e-reimagevm
  • /test e2e-scaleupdown
  • /test unit
  • /test upgrade-private-v15.0
  • /test upgrade-private-v16.1
  • /test upgrade-private-v17.0
  • /test upgrade-v15.0
  • /test upgrade-v16.1
  • /test upgrade-v17.0
  • /test vmimage
  • /test images
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-azure-master-codecov
  • pull-ci-azure-master-e2e-create-20190430
  • pull-ci-azure-master-e2e-create-20191027-private
  • pull-ci-azure-master-e2e-create-20191027-public
  • pull-ci-azure-master-unit
  • pull-ci-azure-master-upgrade-v15.0
  • pull-ci-azure-master-upgrade-v16.1
  • pull-ci-azure-master-upgrade-v17.0
  • pull-ci-openshift-openshift-azure-master-images
  • verify

In response to this:

/test upgrade-v16.1-private

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Contributor Author

/test upgrade-private-v16.1

@ehashman
Copy link
Contributor Author

Based on the PR test history here, I have a suspicion that we've somehow hit a private cluster regression.

Successful e2e-create-private: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/origin-ci-test/pr-logs/pull/openshift_openshift-azure/2316/pull-ci-azure-master-e2e-create-20191027-private/1280653780215402496#1:build-log.txt%3A50

time="2020-07-08T00:28:44Z" level=info msg="check PE existence" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:111"
time="2020-07-08T00:28:44Z" level=info msg="applying PLS deployment" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:118"
time="2020-07-08T00:28:45Z" level=info msg="waiting for arm template deployment to complete" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:134"
time="2020-07-08T00:29:26Z" level=info msg="applying PE deployment" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:142"
time="2020-07-08T00:29:27Z" level=info msg="waiting for arm template deployment to complete" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:158"
time="2020-07-08T00:30:07Z" level=info msg="get PE IP address" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:167"
time="2020-07-08T00:30:08Z" level=debug msg="PE IP Address 172.30.17.4 " func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:172"
time="2020-07-08T00:30:09Z" level=info msg="waiting for API server healthz" func="pkg/cluster.(*Upgrade).WaitForHealthzStatusOk()" file="pkg/cluster/healthcheck.go:41"
time="2020-07-08T00:30:19Z" level=debug msg="ForHTTPStatusOk: will retry on the following error Get https://10.0.0.254/healthz: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" func="pkg/util/wait.ForHTTPStatusOk.func1()" file="pkg/util/wait/wait.go:71"
time="2020-07-08T00:30:30Z" level=debug msg="ForHTTPStatusOk: will retry on the following error Get https://10.0.0.254/healthz: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" func="pkg/util/wait.ForHTTPStatusOk.func1()" file="pkg/util/wait/wait.go:71"
time="2020-07-08T00:30:41Z" level=debug msg="ForHTTPStatusOk: will retry on the following error Get https://10.0.0.254/healthz: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" func="pkg/util/wait.ForHTTPStatusOk.func1()" file="pkg/util/wait/wait.go:71"
time="2020-07-08T00:30:51Z" level=info msg="updating sync pod" func="pkg/cluster.(*Upgrade).CreateOrUpdateSyncPod()" file="pkg/cluster/update_syncpod.go:9"
time="2020-07-08T00:30:54Z" level=info msg="waiting for master-000000 to be ready" func="pkg/cluster.(*Upgrade).WaitForNodesInAgentPoolProfile()" file="pkg/cluster/ready.go:19" 

Example of the failures seen here: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/origin-ci-test/pr-logs/pull/openshift_openshift-azure/2318/pull-ci-azure-master-e2e-create-20191027-private/1281072160361680896#1:build-log.txt%3A50

time="2020-07-09T04:04:21Z" level=info msg="check PE existence" func="pkg/fakerp.GetDeployer.func1()" file="pkg/fakerp/fakerp.go:111"
time="2020-07-09T04:04:24Z" level=info msg="waiting for API server healthz" func="pkg/cluster.(*Upgrade).WaitForHealthzStatusOk()" file="pkg/cluster/healthcheck.go:41"
time="2020-07-09T04:04:34Z" level=debug msg="ForHTTPStatusOk: will retry on the following error Get https://10.0.0.254/healthz: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)" func="pkg/util/wait.ForHTTPStatusOk.func1()" file="pkg/util/wait/wait.go:71" 
... [times out]

I'm not going to spend too much time trying to unblock this right now, but I get the feeling this regression may exist on the release-v19 branch since the branch CI currently does not gate on private cluster creation.

@ehashman
Copy link
Contributor Author

ehashman commented Jul 10, 2020

(also, looking at the code in question, it may very well just be a fakerp bug as opposed to an RP/plugin issue)

@ehashman
Copy link
Contributor Author

OH NO IT'S MUCH DUMBER THAN THAT

log.Info("check PE existence")
exist := nm.privateEndpointExists(ctx, fmt.Sprintf("%s-%s", armconst.PrivateEndpointNamePrefix, cs.Name))
// If we dont check plugin version prefix, code gets triggered on v9 single image updates
// TODO remove when v9 goes away
if strings.HasPrefix(cs.Config.PluginVersion, "v1") {

I will try to fix this.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2020

@ehashman: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
upgrade-private-v16.1 802de55 link /test upgrade-private-v16.1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ehashman
Copy link
Contributor Author

/retest

Copy link
Contributor

@nilsanderselde nilsanderselde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, nilsanderselde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 327de6a into openshift:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants