New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep v20 development #2318
Prep v20 development #2318
Conversation
ehashman
commented
Jul 8, 2020
- Update pluginconfig
- Remove old v14/v18 assets
- Add v20 directories and wire them up
- Update hash tests
- Check in changes from latest goyacc update
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 305 305
Lines 23962 23962
=======================================
Hits 9912 9912
Misses 13470 13470
Partials 580 580 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
except for go generate produced changes that were not already present
/lgtm cancel |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-create-20191027-private |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test upgrade-v16.1-private |
@ehashman: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test upgrade-private-v16.1 |
Based on the PR test history here, I have a suspicion that we've somehow hit a private cluster regression. Successful e2e-create-private: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/origin-ci-test/pr-logs/pull/openshift_openshift-azure/2316/pull-ci-azure-master-e2e-create-20191027-private/1280653780215402496#1:build-log.txt%3A50
Example of the failures seen here: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/origin-ci-test/pr-logs/pull/openshift_openshift-azure/2318/pull-ci-azure-master-e2e-create-20191027-private/1281072160361680896#1:build-log.txt%3A50
I'm not going to spend too much time trying to unblock this right now, but I get the feeling this regression may exist on the release-v19 branch since the branch CI currently does not gate on private cluster creation. |
(also, looking at the code in question, it may very well just be a fakerp bug as opposed to an RP/plugin issue) |
OH NO IT'S MUCH DUMBER THAN THAT openshift-azure/pkg/fakerp/fakerp.go Lines 111 to 116 in 4205d73
I will try to fix this. |
@ehashman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, nilsanderselde The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |