Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add leader lock for cluster-policy-controller upgrades #33

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 2, 2019

I've added a leader lock in the NamespaceSCCAllocationController for upgrades 4.2->4.3
cluster-policy-controller container is split from openshift-controller-manager in 4.3 and will run in kube-controller-manager static pod

@deads2k

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Oct 8, 2019

/test e2e-aws

@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2019

required to remove bootstrapping cycle. tagging.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit db0de1b into openshift:master Oct 8, 2019
stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
Add a RHEL7 dockerfile and standardize format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants