-
Notifications
You must be signed in to change notification settings - Fork 96
Bug 1764498: Remove references to extensions/v1beta1. #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1764498: Remove references to extensions/v1beta1. #43
Conversation
This is deprecated and we should be using apps/v1 instead.
|
@ricardomaraschini: This pull request references Bugzilla bug 1764498, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan @dmage This patch solved the issue but I need help in evaluating the impact of it. This patch affects |
|
/assign @dmage @adambkaplan |
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardomaraschini I think this is good as is.
Deployment was perhaps the first major API added to k8s. It started in the extensions/ API namespace, but was moved to the apps namespace as it moved through beta. You can see that the schemes for apps* are installed (v1, v1beta1, and v1beta2)
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1764498 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is deprecated and we should be using apps/v1 instead.