Skip to content

Conversation

@ricardomaraschini
Copy link
Contributor

This is deprecated and we should be using apps/v1 instead.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2019
This is deprecated and we should be using apps/v1 instead.
@ricardomaraschini ricardomaraschini changed the title WIP - Remove references to extensions/v1beta1. Bug 1764498: Remove references to extensions/v1beta1. Oct 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1764498, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1764498: Remove references to extensions/v1beta1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 29, 2019
@ricardomaraschini
Copy link
Contributor Author

@adambkaplan @dmage This patch solved the issue but I need help in evaluating the impact of it. This patch affects TemplateInstanceController: events related to Deployments reported by TemplateInstanceInformer that fall under extensions/v1beta1 will be ignored, i.e. no more checks for "Readiness".

@ricardomaraschini ricardomaraschini changed the title Bug 1764498: Remove references to extensions/v1beta1. WIP - Bug 1764498: Remove references to extensions/v1beta1. Oct 29, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2019
@ricardomaraschini
Copy link
Contributor Author

/assign @dmage @adambkaplan

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardomaraschini I think this is good as is.

Deployment was perhaps the first major API added to k8s. It started in the extensions/ API namespace, but was moved to the apps namespace as it moved through beta. You can see that the schemes for apps* are installed (v1, v1beta1, and v1beta2)

@ricardomaraschini ricardomaraschini changed the title WIP - Bug 1764498: Remove references to extensions/v1beta1. Bug 1764498: Remove references to extensions/v1beta1. Oct 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2019
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit b28ef71 into openshift:master Oct 29, 2019
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1764498 has been moved to the MODIFIED state.

In response to this:

Bug 1764498: Remove references to extensions/v1beta1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants