Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enterprise-4.1] Edit suggested in file authentication/identity_providers/configuring-github-identity-provider.adoc #14752

Closed
cblecker opened this issue May 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@cblecker
Copy link
Member

commented May 8, 2019

Which section(s) is the issue in?

Registering a GitHub application

What needs fixing?

When offering an example for the homepage URL, it should be something like:
https://console-openshift-console.apps.example-openshift-cluster.com/

When configuring the callback URL, it should be:

https://openshift-authentication-openshift-authentication.apps.<clusterDomain>/oauth2callback/<identityProviderName>/

example:

https://openshift-authentication-openshift-authentication.apps.example-openshift-cluster.com/oauth2callback/githubidp/

The important point is that the specific apps URL endpoint is important. Just providing the API server address isn't enough.

@vikram-redhat

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.