Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enterprise-4.1] Edit suggested in file authentication/identity_providers/configuring-github-identity-provider.adoc #14753

Closed
cblecker opened this issue May 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@cblecker
Copy link
Member

commented May 8, 2019

Which section(s) is the issue in?

Creating the Secret / Creating a ConfigMap

What needs fixing?

The command calls it out, but the docs should be clearer that both these items should go in the openshift-config namespace. It could also be clearer that a configmap is only needed for the certificate bundle, and only if you're using a GitHub Enterprise install with a non-publicly trusted root.

@vikram-redhat

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.