Skip to content

TELCODOCS-2292 - RAN RDS - sysclts #100294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

TELCODOCS-2292 - RAN RDS - sysclts #100294

merged 1 commit into from
Oct 16, 2025

Conversation

@slovern
Copy link
Contributor

@slovern slovern commented Oct 9, 2025 •
edited
Loading

[TELCODOCS-2292](https://issues.redhat.com//browse/TELCODOCS-2292) - RAN RDS - sysclts

Version(s): 4.20

Issue: https://issues.redhat.com/browse/TELCODOCS-2292

Link to docs preview: Kubelet Settings

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 9, 2025 •
edited
Loading

🤖 Thu Oct 16 21:31:49 - Prow CI generated the docs preview:

https://100294--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco-ran-du-rds.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2025
@slovern slovern force-pushed the TELCODOCS-2292 branch 3 times, most recently from 89d58f8 to f141903 Compare October 10, 2025 10:58
kquinn1204
kquinn1204 reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@kquinn1204 kquinn1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on small update

modules/telco-ran-sysctls.adoc Outdated
# ...
----

Note that although these are namespaced they may allow a pod to consume memory or other resources beyond any limits specified in the pod description.
Copy link
Contributor

@kquinn1204 kquinn1204 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note not formatted correctly

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@dgonyier
Copy link

dgonyier commented Oct 16, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

@dgonyier: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

imiller0
imiller0 reviewed Oct 16, 2025
View reviewed changes
modules/telco-ran-sysctls.adoc Outdated
Comment on lines 24 to 28
[NOTE]
====
Although these sysctls are namespaced, they may allow a pod to consume memory or other resources beyond any limits specified in the pod description.
You must ensure that these sysctls do not exhaust platform resources.
==== No newline at end of file
Copy link

@imiller0 imiller0 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a reference to the primary discussion on sysctl use for additional considerations/guidance on their use:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/nodes/working-with-containers#nodes-containers-sysctls

Copy link
Contributor Author

@slovern slovern Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the link

@slovern slovern force-pushed the TELCODOCS-2292 branch 2 times, most recently from 15648ba to f347efa Compare October 16, 2025 20:58
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2025

@slovern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gaurav-nelson gaurav-nelson merged commit 26b3096 into openshift:main Oct 16, 2025
2 checks passed
@gaurav-nelson
Copy link
Contributor

gaurav-nelson commented Oct 16, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 16, 2025

@gaurav-nelson: new pull request created: #100705

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@imiller0 imiller0 imiller0 left review comments

@kquinn1204 kquinn1204 kquinn1204 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@slovern @ocpdocs-previewbot @dgonyier @gaurav-nelson @openshift-cherrypick-robot @imiller0 @kquinn1204